From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wAp0KoOkBWDgSgAA0tVLHw (envelope-from ) for ; Mon, 18 Jan 2021 15:08:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YOdVJoOkBWDnHwAAbx9fmQ (envelope-from ) for ; Mon, 18 Jan 2021 15:08:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55A6094042A for ; Mon, 18 Jan 2021 15:08:51 +0000 (UTC) Received: from localhost ([::1]:46452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1W9C-0007Ta-8Y for larch@yhetil.org; Mon, 18 Jan 2021 10:08:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1W8j-0007S9-Fq for guix-devel@gnu.org; Mon, 18 Jan 2021 10:08:21 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1W8g-0006JQ-91; Mon, 18 Jan 2021 10:08:21 -0500 Received: by mail-wr1-x42f.google.com with SMTP id m4so16770940wrx.9; Mon, 18 Jan 2021 07:08:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=hO4YFasF/ZuLGtGNb5Xo58fDwRrWvrV0wZbQvuwk31U=; b=UhGbnjo9A0oGeW5bp7LGGDAuf3blYIOTEO6XZYXuzaRTI1e2/c1uA8sSc65zE3sSCY vxpWD97gsrb98wmtMZkuYrvAxowaJHzysDMOsD69gX/RRqZpKW3gGG4lDc+tUhofDXSW vDAr4PNjrtRa3DiBhXu5oczE3qXg/3ZEJAI7UX8bmkNUV6xTy1akn/9wNuM9p/5C1wlx ba9E92lfqedpZHKcLSDVn1f/qKn1+zICDit6lYZeGKHpTm+gT45DnPIMbl4x8/8ncvfe 0N0XqvdYxwctkBG6noMMyN9/+FmlfAxhOMUPrI8cK7N1YP8OrukEmT6czl75MCwBFmd5 CAIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=hO4YFasF/ZuLGtGNb5Xo58fDwRrWvrV0wZbQvuwk31U=; b=HeLWCs+A1aPwBcpDR/E00Kbc0abG1A9E0hKCc/jQmS6452gbBM3QGrQWAgtoXbwcSW 8IvWI2qwapqAIih542/J7z9sYICjYcGdcSL/gCozKQFcSHL78MUxi8qUuAF1lieaZwIq vHzjx/QTQpZnWCUYLJ8YzwJJV39MrvZm9rS1SMYkfA8Ifly3Xzp+tr7IqC6zWP+3I6Al bJdDp9MkPWDKZNp5JJW9Rh0tWZ/fyQc5H/kJHHbGzVtkApz4YQYPhpxhuW/svKjLC2GB mGhXHN50K11MBOIn6FTHw7EQowq9qo7cvE75t/d+WI9CKKzYvPLstZmE88ae/3pMdsCS r6oQ== X-Gm-Message-State: AOAM531QGO0mY0NCQqKLBfucQM6zMbXoAe9Z+uznJzoy68fywd2FvR61 1geAvCjrwGK3MufihEuaY5pWe9cDL8k= X-Google-Smtp-Source: ABdhPJwjaFl+CDoPKj9uTjOOZanFv4Jf4PhaMlVqtBOhS9E+r1D9jlK1OermIbQIIjVthWA85VLjvQ== X-Received: by 2002:adf:f0d0:: with SMTP id x16mr26983610wro.162.1610982496713; Mon, 18 Jan 2021 07:08:16 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id n9sm29924361wrq.41.2021.01.18.07.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 07:08:15 -0800 (PST) From: zimoun To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Magali Subject: Re: [Outreachy] Strategy to implement guix git log --pretty= In-Reply-To: <87y2gv1a3d.fsf@gnu.org> References: <87y2gv1a3d.fsf@gnu.org> Date: Mon, 18 Jan 2021 16:02:51 +0100 Message-ID: <86a6t69tk4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=UhGbnjo9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 55A6094042A X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: bp5hNZvND02v Hi Ludo, On Thu, 14 Jan 2021 at 22:29, Ludovic Court=C3=A8s wrote: > I was going to suggest postponing this feature, but I see in the repo > you already came up with a reasonable solution (maybe not fool-proof, > because it should be possible to escape the percent character, and then > you can=E2=80=99t just use regexps, but it=E2=80=99s probably good enough= .) Yeah, my initial idea was to use PEG. But the documentation is not easy to grasp so using regular expressions seems enough to underline the functionality, with the option to improve later. Well, the reasonable goal for the project is to run something as: ./pre-inst-env guix git log --grep=3D --pretty=3D=E2=80=9C%h %s=E2= =80=9D What is not clear for now: - walk the history tree; currently done with something similar to =E2=80=99commit-closure=E2=80=99 and I do not know if all the branches a= t merge points are correctly walked; - lazy walk, for example: =E2=80=9Cgit log --oneline | head -n10=E2=80=9D = does not need to traverse all the history tree but only the first 10 commits. Something like =E2=80=9Cco-routine=E2=80=9C (not sure if it is the corre= ct word). It is not a big deal for now because it is fast enough; but far to be optimal. ;-) And these start being an issue with a couple channels. Cheers, simon