unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / Atom feed
* Patches that should be applied in the Future
@ 2021-10-28 12:59 Jelle Licht
  2021-10-29 15:10 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Jelle Licht @ 2021-10-28 12:59 UTC (permalink / raw)
  To: guix-devel

Hello there guix,

All of this is about core-updates-frozen at revision dac8d013bd1.

`c-ares' in gnu/packages/adns.scm has its tests disabled; On my x86_64
machine, it seems the tests for c-ares pass just fine because of the
defined GTEST_FILTER when I re-enable them;

With my limited git-foo, it seems that this particular change comes from
merging signed/master back into c.u.f. in e486b2b674b. To me it seems
that (re-?)introducing the `tests? #f' might have been something silly
done by git-merge.

This is still a pretty good situation to be in; we have working tests
that we simply don't run :). Practically, I wonder what the next step
would be to make sure things go well in the future;

We can't 'fix' c.u.f. this late in the cycle without rebuilding pretty
much everything. In my limited understanding of juggling many branches,
it also seems that merging c.u.f. into master (and later, core-updates)
will have this `tests? #f' being propagated.

What can we do to make sure we won't simply forget to apply this and
other such changes? 

- Jelle


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patches that should be applied in the Future
  2021-10-28 12:59 Patches that should be applied in the Future Jelle Licht
@ 2021-10-29 15:10 ` Ludovic Courtès
  2021-11-02  8:47   ` Jelle Licht
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2021-10-29 15:10 UTC (permalink / raw)
  To: Jelle Licht; +Cc: guix-devel

Hi!

Jelle Licht <jlicht@fsfe.org> skribis:

> What can we do to make sure we won't simply forget to apply this and
> other such changes? 

I’d suggest making this change right away in ‘core-updates’.

After all, the reason we introduced ‘-frozen’ is so we could keep having
fun on ‘core-updates’ while things are being stabilized elsewhere.

Ludo’.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patches that should be applied in the Future
  2021-10-29 15:10 ` Ludovic Courtès
@ 2021-11-02  8:47   ` Jelle Licht
  0 siblings, 0 replies; 3+ messages in thread
From: Jelle Licht @ 2021-11-02  8:47 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Ludovic Courtès <ludo@gnu.org> writes:

> Hi!
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> What can we do to make sure we won't simply forget to apply this and
>> other such changes? 
>
> I’d suggest making this change right away in ‘core-updates’.
We need to override a change that has not landed in core-updates yet; it
only exists on c.u.f. last I checked.

I could merge c.u.f. into c.u. this week and subsequently fix this issue
in either the merge commit itself or a fixup immediately after, if that
is what you are saying.

> After all, the reason we introduced ‘-frozen’ is so we could keep having
> fun on ‘core-updates’ while things are being stabilized elsewhere.

For some definitions of "fun" :-). 

- Jelle


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-02  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 12:59 Patches that should be applied in the Future Jelle Licht
2021-10-29 15:10 ` Ludovic Courtès
2021-11-02  8:47   ` Jelle Licht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).