From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SLNfGH6tR1/AVAAA0tVLHw (envelope-from ) for ; Thu, 27 Aug 2020 12:56:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0HwwFH6tR18iBQAA1q6Kng (envelope-from ) for ; Thu, 27 Aug 2020 12:56:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 085A3940876 for ; Thu, 27 Aug 2020 12:56:29 +0000 (UTC) Received: from localhost ([::1]:42804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBHS8-0000rg-NR for larch@yhetil.org; Thu, 27 Aug 2020 08:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBHRz-0000po-EW for guix-devel@gnu.org; Thu, 27 Aug 2020 08:56:19 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:50262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBHRw-0000TU-Oe for guix-devel@gnu.org; Thu, 27 Aug 2020 08:56:18 -0400 Received: by mail-wm1-x336.google.com with SMTP id t2so5088365wma.0 for ; Thu, 27 Aug 2020 05:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=jbmWVjfjDX4ytAkViPUVufdwPNhoeYnr+BBkWV7/aBc=; b=PcyLpsj9G6TeRwDTH+jr0OuKZc6BUeEbrH08AVUL6kPCa5MW1k6fTU821MC3hXq0Rn XNLJnqULogiycNOdnVwRACoLqrbkchrrtVjpn8zBz2OmOCIefPFfROP6NsMTbulaB8TY XJL/nvZ8yYd+d/OFAKiqYEdhxwH6dil//d5uMKWyXa+ELuaNCb6beSaS1EbXBBUWv0Vx mYPhBZuKb/ICj4R1Pn7uVm+m9eg0zsLBRIDdEqxVgSVpwzw765qVslCJzYF4SaEVi7pE o+FPaPgltuyX+Laq3cYm/dMrZl/NEoXml2DW+otdZPQmnsfo72M3ouOf0L2DVZSEU0uu 6rKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=jbmWVjfjDX4ytAkViPUVufdwPNhoeYnr+BBkWV7/aBc=; b=cF6GB7iTtgrg8yoYxBxix9oFxzfXUy+qQOBU0Eb6VjWctQqu8w2SczFPL/ptiQYVB2 qFybJLn2qDHsaPjMSwj4LIbmZ+eZ7oyNFgU/+r1VRP/HL8UeD6aqRNqowQwuQaYKakxY zbEq1xIudpG4z18iog5P/vneRkti2YpgSghI6l/kD2bJ+r0uyHKX30p7KITWwnsF7m8y S2dG2unQF0wHQcKmVr4jZFw87vdTQ0Xpqyh64BKwxuNy6zDD5KjtXZJ0MG9khPuKRTib oK7Bis/wAQG58Jhb+ek0twF4h9fWXyAPSnzV+ZzhxjSYlGcmBGJFWAuDDQ4kNmUFYpeC tCnw== X-Gm-Message-State: AOAM531kb0t4oBy2XOTiCeYAxDq5aIp4PMYyc/Vd+bff/1NpszwQoTwF OUJVCefg2m/fPecDgMTsDyjhl40Q1Qw= X-Google-Smtp-Source: ABdhPJwqdhkaaQ9GZLeNQGD6RzKp1K0IJ71TmvEZXIvNXAvM00oqU7p1rbyhLxX8qTsnIGGTQaYSMQ== X-Received: by 2002:a7b:c243:: with SMTP id b3mr11642741wmj.178.1598532974562; Thu, 27 Aug 2020 05:56:14 -0700 (PDT) Received: from lili (57.246.195.77.rev.sfr.net. [77.195.246.57]) by smtp.gmail.com with ESMTPSA id n24sm4750889wmi.36.2020.08.27.05.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 05:56:14 -0700 (PDT) From: zimoun To: Pierre Neidhardt , guix-devel@gnu.org Subject: Re: File search progress: database review and question on triggers In-Reply-To: <87eenspcf8.fsf@ambrevar.xyz> References: <87sgcuh8rb.fsf@ambrevar.xyz> <86imd4e7cr.fsf@gmail.com> <87eenspcf8.fsf@ambrevar.xyz> Date: Thu, 27 Aug 2020 14:56:12 +0200 Message-ID: <865z94dz83.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=PcyLpsj9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: r3UFZ/sqaroA Hi Pierre, On Thu, 27 Aug 2020 at 13:15, Pierre Neidhardt wrote: > zimoun writes: > >> If you are going to an local SQL database, my two questions are: >> >> a) >> Which part would update it? =E2=80=9Cguix pull=E2=80=9D? Other? Even = using >> substitutes, the channels and co could lead to an extra cost and so what >> is acceptable and what is not? > > I suggest fetching database updates when performing the filesearch, just > like `guix size` does. I am not sure to see how. One needs all the database to search inside and cannot know in advance which packages etc.. Contrary to =E2=80=9Cguix = size=E2=80=9D which manipulates the graph and then download the missing parts. Therefore, your suggestion is to download all the database the first time the user run =E2=80=9Cguix filesearch=E2=80=9D, i.e., download ~10MiB. Then each time the user runs =E2=80=9Cguix pull=E2=80=9D then =E2=80=9Cguix= filesearch=E2=80=9D, two options, either download the new database for this last Guix generation, or either download a diff (not sure the complexity is worth for ~10MiB). Right? And what about the channels? Because if I read correctly, =E2=80=9Cguix si= ze=E2=80=9D fails when =E2=80=9Cno available substitute information=E2=80=9C. >> b) >> Could you also include other fields such that =E2=80=9Csynopsis=E2=80=9D= and >> =E2=80=9Cdescription=E2=80=9D? Because it could speed up =E2=80=9Cguix = search=E2=80=9D without adding >> (or modifying) the current cache >> (~/config/guix/current/lib/package.cache); discussed at length in >> #39258 . > > I think this is a bit beyond the scope of this patch set. I'd rather > focus on files exclusively for now and proceed one step at a time :) I do not think it is beyond the scope because Arun introduced an SQLite database for improving =E2=80=9Cguix search=E2=80=9D. But this path had be= en stopped because of =E2=80=9Cintroducing complexity=E2=80=9D [1]. Therefore, if =E2= =80=9Cguix filesearch=E2=80=9D introduces a SQL cache, then it seems a good idea to be= also usable by =E2=80=9Cguix search=E2=80=9D. Well, if the table is extended with the fields =E2=80=9Csynopsis=E2=80=9D a= nd =E2=80=9Cdescription=E2=80=9D then what is the size of the database? Does = it kill the lookup performance? [1] http://issues.guix.gnu.org/issue/39258#7 Cheers, simon