From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kTunBK13UGGaYgAAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 15:37:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kBA4O6x3UGFaUAAAbx9fmQ (envelope-from ) for ; Sun, 26 Sep 2021 13:37:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 69D82318E9 for ; Sun, 26 Sep 2021 15:37:48 +0200 (CEST) Received: from localhost ([::1]:51328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUULj-00073E-Jq for larch@yhetil.org; Sun, 26 Sep 2021 09:37:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUULS-00070Z-0X for guix-devel@gnu.org; Sun, 26 Sep 2021 09:37:30 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:49624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUULQ-0005jT-12; Sun, 26 Sep 2021 09:37:29 -0400 From: Jelle Licht To: pinoaffe , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Merging the =?utf-8?B?4oCcYmluYXJ54oCd?= NPM importer? In-Reply-To: <87tuiaq411.fsf@airmail.cc> References: <87mto8zpll.fsf@airmail.cc> <87zgs3829p.fsf@gnu.org> <87tuiaq411.fsf@airmail.cc> Date: Sun, 26 Sep 2021 15:37:22 +0200 Message-ID: <864ka7qwz1.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.69.89.151; envelope-from=jlicht@fsfe.org; helo=mail1.fsfe.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632663468; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=/uxK+cVdpHthNsDyaog0bI6D59P2g1/XKp7/HMITy8k=; b=bLs+2edr2UB9dnzyvIGz4FCBU4Qa5rcdF953VvdeSxNcVUAOUHGSeOI3+MiW2oEOjkZEfo tLPdgh54YVOrPyJlxkZuh8Ms0Jl4hxR0jPT/XQ4N2egz2XtJJjfVJ2fAXqnBM6d2EhjzPK hFWcAx3BZDSZY1R8CD3qnFhwn6KeH/X0yLfnraGeJCDpzcqpKlJo7UCFcLVL8aMqvgkCGf NxHLZqGeBaS5SDnfGT8GFDwL+4GinURy0pTPnHa5O3Vqwp0b4amXLg28FBI8U88/g4l5Jv UM/9AGoo6gFc/TBvXDdNM73pe4i27qi8qekBw0enqveN8NaEuCeeVVN2/fU5RQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632663468; a=rsa-sha256; cv=none; b=K/oKkjyYy/cbteQUcatoZp+tBcTJ9jz6ueFS42blDMB8y6eycCyoppjxnZwDbINWuOFJxY pCsiBfnHjBXjq59YhQ4zHgQPA+k97K6F4yLqofZxpGQROdTqBZUMFv/OSDCnj5nolNUJvm cOKnrjmNo1Dvuyec0zR/0ML1P72jeYtLahHAjYWE61191p0C0JV2pnAvHMpbh7bSX+Poy0 ZElY8sU1JIC4m61DvtCBHD1WgLtyFvLvIXc11L+WOusDSPEQsrZm/VJemPo0npseFHt4Kf uhThzSQRi/WtAS/LnEY4wDYB25DAIk2GqiJHAP+HuM8mhTzTU8vteYuiGupvPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.19 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 69D82318E9 X-Spam-Score: -0.19 X-Migadu-Scanner: scn1.migadu.com X-TUID: yBMlq8N1e+ar Hello there, pinoaffe writes: > Hi! > I do however think that quite a couple of improvements would be > necessary before this can be merged The major ones I can think of are; - Be rebased on current master (or perhaps core-updates-fixed?) - tests - documentation Could you perhaps list some additional blockers? We can always refine and improve on an acceptable upstreamed version, since it will be a once-and-done tool instead of some stable API. Thanks, - Jelle