From mboxrd@z Thu Jan 1 00:00:00 1970 From: myglc2 Subject: Re: Non-graphical GRUB configuration Date: Mon, 17 Apr 2017 09:44:06 -0400 Message-ID: <861ssrxi6x.fsf@gmail.com> References: <20170331125956.rhlwjg45vwo3pgwh@abyayala> <20170331234321.GA10435@jasmine> <20170401072740.kgzz3zbtikn5hpg5@abyayala> <20170401202901.GA10480@jasmine> <86vaqmwz3c.fsf@gmail.com> <20170402210620.GA26945@jasmine> <20170405115919.GA28944@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d06wx-0003LH-Vs for guix-devel@gnu.org; Mon, 17 Apr 2017 09:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d06wx-0001as-7h for guix-devel@gnu.org; Mon, 17 Apr 2017 09:44:16 -0400 In-Reply-To: <20170405115919.GA28944@jasmine> (Leo Famulari's message of "Wed, 5 Apr 2017 07:59:19 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org On 04/05/2017 at 07:59 Leo Famulari writes: > On Sun, Apr 02, 2017 at 05:06:20PM -0400, Leo Famulari wrote: >> Based on the GRUB manual [0], how about this plan? >> >> We'd add these fields to (grub-configuration): >> >> terminal-outputs: One or more symbols: console, serial, gfxterm, >> ofconsole, vga_text. Default gfxterm. >> >> terminal-inputs: One or more symbols: console, serial, ofconsole, >> at_keyboard,usb_keyboard. Default unset. >> >> If 'terminal-inputs' or 'serial-*' are unset, we do what we do now: >> nothing. If 'terminal-outputs' is unset, we also do the same thing we >> now, which is set it to gfxterm. >> >> If any of them are set, we'd insert the corresponding text into the >> generated grub.cfg. >> >> If terminal-outputs does not include the symbol 'gfxterm', we'd disable >> the "setup_gfxterm" function. > > Here's a WIP patch that I'd like some advice about. It does insert the > relevant text into grub.cfg, although I recommend testing it in a > virtual machine for now. > > Questions: > > 1) In general, is this approach okay? > > 2) I think that (grub-setup-io) should be used in > (grub-configuration-file) instead of (eye-candy). But, when I try > calling it there, in the builder, it has no effect on grub.cfg. Any > suggestions for debugging this? Hey Leo, As reported earlier, this works for me. IMO it is good to go. If there is anything I can do to help, please let me know.