From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sPbCBOGNQGZbIgAAe85BDQ:P1 (envelope-from ) for ; Sun, 12 May 2024 11:37:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sPbCBOGNQGZbIgAAe85BDQ (envelope-from ) for ; Sun, 12 May 2024 11:37:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=bAMpNG0c; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715506657; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=dqgvjY6xUTY0/3gQneBcJ6Pz0qmRo5cqwJzMgjXRuDA=; b=ts/+0klbaor3JP7Yt+C7YoGeSQmZsDgM8LWIdGpKEdiqXMLKvrZ7ewVWacqULSOuSdfXTZ OUNcdjqxQoZS7gtE6SL+tKSI1mVWa1LprI8Oo/RBl/b/0HrZhEYwWsKOocUaGHWoAWT7CH Vm4nt+NSTaAiX+Udam5ofSAIBaF7zMF/SlwrO248ucAgGe6r2qopehdZO+IGbX7U3TAIzx RzJ98HU0sZ/efdTapAbVk+6nURg3f1hXzq9ACRRuSJ3tYrazHGM9WV7lTKwCxo4NDcRMHE LJdKMVJ99kCdJ0I1Gs24ra5Wj+rC3vW9JoGXl9uWuC8s8rvzgQA8XefYkBu7WA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=bAMpNG0c; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715506657; a=rsa-sha256; cv=none; b=dwaVGPXgBjqSnunyu1dkxB3Lv8d3QMhPcVJ82RihI7rPKH5V28bMKSGCbsptNCPjbodA20 Lf//9qt7IfOJxk7xL+FHlANGBw/egRRdVD95Y7elJeqdnKSb4zymfuS+lgVo5H+oxtW9vu GO+MbFK1WPchuZtaU74/eDvWwwDBHKVoG0bFETUyADCbqcRQCFrQlcsdCINd0lnoPHElUj f9mxDXEd/xVg8jcQ+9HM5ktj0FJT+xmygY5+NGwY7i3mA5ZFvAcVQVVo7vC6bMxBbmiSc2 iMxkKEqhCv4OxMk6HTM8lwWPeSJiENLmbtSrWeWIjsZJRVy00BdBEY94qH8JoQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B83D669C62 for ; Sun, 12 May 2024 11:37:36 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s65dn-0003z5-S6; Sun, 12 May 2024 05:37:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s65de-0003wx-1X; Sun, 12 May 2024 05:37:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s65dZ-00006m-M5; Sun, 12 May 2024 05:36:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=dqgvjY6xUTY0/3gQneBcJ6Pz0qmRo5cqwJzMgjXRuDA=; b=bAMpNG0cellJMixbBA5F ityn33XjOG0YT0Bd+FWiJF5sVg1mWjYnAlT9kRCCUJv/xvyPqTT3H0pyOLFyEJTPJwuEkjK7F9/xz NvY1PhOVCBiDn1fEV2ZR0rTPTqz4481/SoKaHEWnvfwfInScWzNf9cDbhy6Jr+U3ZSnOxL6akQtGe Jnvtdn9ift7Rnw26eiMxyq4j0mteQ6BJi++afsu5Oa0Qk2Y4UJl2/fhZPhORFGc6K9yFb+LRVPVEO TjIi6do6puW09CFc0wIkaW6g55e5YmcIbCAgs6jQuA+u4Vq0OttaUgD7mWOTHA1SxbcIVnHJC/xsM 3mxquRHyfoN+mw==; Date: Sun, 12 May 2024 12:36:46 +0300 Message-Id: <861q671idt.fsf@gnu.org> From: Eli Zaretskii To: Nicolas Graves Cc: monnier@iro.umontreal.ca, ludo@gnu.org, emacs-devel@gnu.org, andrew@trop.in, guix-devel@gnu.org, bjorn.bidar@thaodan.de, rudi@constantly.at, felix.lechner@lease-up.com In-Reply-To: <87cyprbhap.fsf@ngraves.fr> (message from Nicolas Graves on Sun, 12 May 2024 09:50:06 +0200) Subject: Re: [Nicolas Graves] [PATCH v6 01/10] rde: emacs: Start emacs in --daemon mode, with shepherd and pid-file References: <20240410234923.29319-2-ngraves@ngraves.fr> <875xwotg35.fsf@trop.in> <87zfu0m9ps.fsf@ngraves.fr> <87jzl22u5w.fsf@gnu.org> <87frvp4a4u.fsf@ngraves.fr> <87msow5cm8.fsf@ngraves.fr> <87msow7xrs.fsf@ngraves.fr> <86bk5b1r1i.fsf@gnu.org> <87cyprbhap.fsf@ngraves.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -11.13 X-Spam-Score: -11.13 X-Migadu-Queue-Id: B83D669C62 X-Migadu-Scanner: mx13.migadu.com X-TUID: hN95l3hw9Tm5 > From: Nicolas Graves > Cc: monnier@iro.umontreal.ca, ludo@gnu.org, emacs-devel@gnu.org, > andrew@trop.in, guix-devel@gnu.org, bjorn.bidar@thaodan.de, > rudi@constantly.at, felix.lechner@lease-up.com > Date: Sun, 12 May 2024 09:50:06 +0200 > > On 2024-05-12 09:29, Eli Zaretskii wrote: > > > Thanks. What was the motivation for this, again? > > A light summary (all is in the preceding exchanges in the mailing list): > > - Ludovic Courtès suggested this change because linking with systemd is > unnecessary (very light usage), and increases the attack surface. > > - Rudolf Schlatte highlights that Lennart Poettering says that the > notify protocol is stable and independent of libsystemd. > https://mastodon.social/@pid_eins/112202687764571433 > https://mastodon.social/@pid_eins/112202696589971319 > This mastondon thread itself contains a lot of info/answers about > this, including examples of similar work on other projects: > - https://github.com/FRRouting/frr/pull/8508 > - https://github.com/OISF/suricata/pull/10757 > Lennart Poettering also says that the protocol has been stable for a > decade and will surely be for at least another decade. > > This should also answer the worry about significant maintenance. I'm sorry, but I'm wary of believing such assertions, especially when systemd is involved. E.g., what's to prevent people from asking us to support the various forks of systemd as well? Reimplementing everything in-house doesn't scale, definitely not in a project as large as Emacs. So the argument about smaller attack surface doesn't really convince me. Emacs uses quite a lot of external libraries to the benefit of our users, and that will not change any time soon. > What I'm less confident about is edge cases as I highlighted earlier > (are there cases where systemd's safe_atoi is necessary compared to > strtol ? Is it fine if LISTEN_FDS is set but LISTEN_PID unset, or > should be check for LISTEN_PID definition too ?) This is exactly the kind of maintenance burden I'm concerned about: who will help us answer these questions, now and in the future? We cannot rely on having systemd experts on board at all times. > >> > - The sd_notify code is taken from > >> > https://www.freedesktop.org/software/systemd/man/devel/sd_notify.html#Notes > > > > I'm not sure what would be the legal aspects of such code borrowing. > > The code is given as MIT-0, hence also the two different licenses for > the two functions sd_notify and sd_is_socket. Not an expert on licenses > either, but with a proper flag about what this function's license is, I > guess it should be fine, since other projects also do that. The license is only half of the problem. Every non-trivial contribution to Emacs must have its copyright assigned to the FSF, because the FSF is in charge of protecting the Emacs sources, something that only the copyright holder can do, at least in some countries. You will need to assign the copyright as well (a relatively simple procedure of filling a form and emailing it), but if the code is not yours, you cannot assign its copyright.