Re: 06/06: gnu: Add weasyprint.

Re: 06/06: gnu: Add weasyprint.

[Ludovic Courtès]

Hi Hartmut,

guix-commits@gnu.org skribis:

> +  (package
> +    (name "weasyprint")
> +    (version "50")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "WeasyPrint" version))
> +       (sha256
> +        (base32 "0invs96zvmcr6wh5klj52jrcnr9qg150v9wpmbhcsf3vv1d1hbcw"))
> +       (patches (search-patches "weasyprint-library-paths.patch"))))

You forgot to push the patch.  Could you add it?

Thanks,
Ludo’.

Re: 06/06: gnu: Add weasyprint.

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Hartmut, Ludo',

Ludovic Courtès 写道：
>> +       (patches (search-patches 
>> "weasyprint-library-paths.patch"))))
>
> You forgot to push the patch.  Could you add it?

I've reverted this patch for now to keep master relatively happy.

Good night!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: 06/06: gnu: Add weasyprint.

[Hartmut Goebel]

[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]

Am 22.10.19 um 23:51 schrieb Tobias Geerinckx-Rice:
> Ludo:
>> You forgot to push the patch.  Could you add it?
>
> I've reverted this patch for now to keep master relatively happy.
>
Ups, soory. New package including the patch in
77e0cebcadc8b96613832e1554e326d48e20f72f

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 06/06: gnu: Add weasyprint.

[Ludovic Courtès]

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Am 22.10.19 um 23:51 schrieb Tobias Geerinckx-Rice:
>> Ludo:
>>> You forgot to push the patch.  Could you add it?
>>
>> I've reverted this patch for now to keep master relatively happy.
>>
> Ups, soory. New package including the patch in
> 77e0cebcadc8b96613832e1554e326d48e20f72f

Thank you!

Another thing: could you add a couple of lines at the top of the patch
stating what the patch does and what its upstream status is?  (For
example you can add a link to the upstream commit it comes from, if
applicable.)

Ludo’.

Re: 06/06: gnu: Add weasyprint.

[Hartmut Goebel]

Am 23.10.19 um 16:24 schrieb Ludovic Courtès:
>
> Another thing: could you add a couple of lines at the top of the patch

Done: e30808ddb33f4aa0c4940ce8596ddc71ff55ed2a

Thanks for the review.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |