Re: [PATCH] gnu: ghc-split: Update dependencies.

[Eric Bavier <ericbavier@openmailbox.org>]

On 2015-10-22 11:16, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-before
>>> +          'configure 'update-cabal
>>> +          ;; the cabal file on hackage is updated, but the tar.gz 
>>> does not
>>> +          ;; include it.
>>> +          (lambda* _
>>> +            (copy-file (assoc-ref %build-inputs 
>>> "ghc-split-cabal-update")
>>> +                       "split.cabal"))))))
>>>      (inputs
>>> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
>>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>>> +       ("ghc-split-cabal-update"
>>> +        ,(origin
>>> +           (method url-fetch)
>>> +           (uri (string-append
>>> +                 "https://hackage.haskell.org/package/split-"
>>> +                 version "/revision/1.cabal"))
>>> +           (sha256
>>> +            (base32
>>> +             
>>> "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>>>      (home-page "http://hackage.haskell.org/package/split")
>>>      (synopsis
>>>       "Combinator library for splitting lists")
>> 
>> Similarly to the xmonad cabal patch, perhaps this could be addressed 
>> with
>> 
>>   #:configure-flags '("--allow-newer=base")
> 
> Nope, that option doesn't exist, i've checked.
> 
>> with an appropriate comment.  Otherwise using an origin snippet.
> 
> I've made it into a (substitute* "split.cabal" ..) which simply updates
> the version number of base ("base <4.8" → "base <4.9"), in accordance
> with the change on Hackage.  A comment is provided.

OK

> The patches responding to your latest batch of comments have been 
> pushed
> to the wip-haskell-… branch.

Great! I'll take one last look, then I think we can merge.  WDYT?

-- 
`~Eric