From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Richard Sent <richard@freakingpenguin.com>
Cc: guix-devel@gnu.org
Subject: Re: Codifying/Documenting Guix commit message conventions?
Date: Sat, 29 Jun 2024 08:51:59 +0200 [thread overview]
Message-ID: <833a84d6421dca2f91c80668430a03b445c91475.camel@gmail.com> (raw)
In-Reply-To: <877ce8a6yh.fsf@gmail.com>
Hi Guix,
Am Freitag, dem 28.06.2024 um 21:11 -0400 schrieb Maxim Cournoyer:
> Richard Sent <richard@freakingpenguin.com> writes:
>
> > Another one seems to be the [security fixes], [fixes CVE-...], and
> > [fixes TROVE-...] blocks added to certain header lines. What other
> > tags exist? There seems to be inconsistency here when referring to
> > multiple CVEs. For example, when a fixes tag references multiple
> > CVEs you can find.
> >
> > [fixes CVE-2020-10700, CVE-2020-10704] [5]
> > [fixes CVE-2020-3898 & CVE-2019-8842] [6]
> > [fixes CVE-2023-{28755, 28756}] [7]
>
> I think these are likely to bust the 70 characters limit for a git
> commit summary line, so perhaps we could standardize on [fixes CVE-
> XXX] for single CVEs or [security fixes] when there are more than one
> (listing the CVEs in the commit message body instead then).
I think we should use a "Fixes: [short description] <URI>" footer for
both Guix and upstream bugs, that can easily be parsed – hopefully by
both humans and machines. That would give the interested reader the
(contextual) information they need, while also leaving the main body to
a more thorough description of the patch itself.
Cheers
>
next prev parent reply other threads:[~2024-06-29 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 23:04 Codifying/Documenting Guix commit message conventions? Richard Sent
2024-06-28 8:59 ` Andreas Enge
2024-06-29 1:11 ` Maxim Cournoyer
2024-06-29 1:42 ` Richard Sent
2024-06-29 6:51 ` Liliana Marie Prikler [this message]
2024-06-30 1:11 ` Maxim Cournoyer
2024-06-30 6:25 ` Liliana Marie Prikler
2024-07-01 14:14 ` Maxim Cournoyer
2024-07-01 22:17 ` Richard Sent
2024-07-02 2:20 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833a84d6421dca2f91c80668430a03b445c91475.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=richard@freakingpenguin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).