From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iJlaEAvP+GTCSwEAG6o9tA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 21:12:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iJlaEAvP+GTCSwEAG6o9tA (envelope-from ) for ; Wed, 06 Sep 2023 21:12:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB1F852F9D for ; Wed, 6 Sep 2023 21:12:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=PWWDXIqg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694027531; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=A3QS/wNWIhHZqltNBaTGFbknwZ9fgSitGFQDN3MLZY8=; b=QScbFREQm48u4YLtJspQ+CFno/rFw5a+K7P1gTadRgZ4R3KgMkOXr0NxKWPI/9jLkFXTbz cleK3n33vfPnILqLG0MjnBekGaeJLAq6HHveKB5t8unXdnYcPVDgN0tr8ABSitatmhT5cv SqKljTfyA4W/TuvrPk1gwodwOe0dxaHaBMdlfkujAvKuHwR12DDhYiufodFkCLi5DEyBfZ A8Ng6aLXnj/TxHA1OpVTiZ7SQHlGwY3ivzMofE9RkTlP9KBvX24jIje5V/Ck1rBjwnM5QU NbOpygIN7rHqw44KitZKV0ymgBYQ2N9NkAOiCHPZjqpjfyQ7RjlkW3enLMzASg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694027531; a=rsa-sha256; cv=none; b=OCX73bVJJAByY0kEJK8UvZIF5DgGchyOcHQNLb0ruQU3ofp8xgX22IiCGGoh4etE1LNHZ4 TesZuYGgmb4d+vZT5wEhPM6xSBeYPrjaPq+fhcFzN4bz6F7OaKr8z1ai2QrtWCvGlmcfoW aOvS5IbP641hI4dKbEXMj0Wi3CAKoI9svVRuhCkKq0mxLwtvR2yXpFlv8BN7rrSN8gxi/c VBaULJPrWLLU1WhI/A66TVSqyU2lanrVS1/BVPqSuyEJlmb2eQoCLPSN4TepGbj0eWYyni NnWGyhzwbb+HenfzM6emS1unITA1BpUiTvqtHvuSEqn3JujIoK8j4y5dZAf1hQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=PWWDXIqg; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxvu-0003x2-0n; Wed, 06 Sep 2023 15:11:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxvs-0003wb-G3 for guix-devel@gnu.org; Wed, 06 Sep 2023 15:11:20 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdxvl-0001mX-AE for guix-devel@gnu.org; Wed, 06 Sep 2023 15:11:20 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-99bf1f632b8so9498366b.1 for ; Wed, 06 Sep 2023 12:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694027471; x=1694632271; darn=gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=A3QS/wNWIhHZqltNBaTGFbknwZ9fgSitGFQDN3MLZY8=; b=PWWDXIqg3EjGtrrDTub1ASQX3YIh6riakcyRDI/ekr+4h1e4GBzs8g+/aj8yhshq7z dEmG2WyWN+fhPiZODuYJkhd0ke7jOmrkQEL/Oir3QtBFFbRRocI/Un322tzQU+zUQZ+5 1pBkKWuIhfriwHI+3HYbUQrxEtliMp6iy0IFmSg8YamtVZ+JJpSqXldvRV/UR54LXiZc xOxDLaPAiEAEW92f8X8CRnoEkmJZfa5ocjomdTQizzYf3l+pydvoUTFqQWAyhEE7tNzh KGNKQYu/Qh7BaaewBFuNVNLpnCVX4KLP5+/+Ku2xJV6BE3/4g3EEpwXZNzRlRhc2ypHv ecWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694027471; x=1694632271; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A3QS/wNWIhHZqltNBaTGFbknwZ9fgSitGFQDN3MLZY8=; b=ZvYvi0et5uD0VW77O9GJ1SzHQeNJOk/G/4HCOg3o2l8UE4AM8P3DyRCru/8T6GImS4 tckTdaIo8immCsd1Fgmju5h9G8ViPUcbf33eFzrKzYg8RWde2eQMPEBLp3l+pssNLjhW UzjT+plHNyM6aP+aPeg7TeTvTsZ2zHTXptoOOonWITTguKwz1mhCEJLUKdmH/R0Fz9+3 GN2y2VNNrUWDxBNXH+M7mXdamgtwGPf914HtA5flzovr8Hu/ICB7sbtpLJnztcQAbJVO Yg7wWVbtvcmqVWUgeQYfud3fKMPqC8Xv53PUhikrW6/yJb8ll3Tl6OvQIm4uqF+KRaha 2Xqw== X-Gm-Message-State: AOJu0Yx7o+F0qypf2nv0gOB+5g+jGErQZAhUnhknAxDzCkfPTXNJF7zf 7VHvSvx2V1I603yDRv+7KZM= X-Google-Smtp-Source: AGHT+IFv9TpZWAyoeEXCJJosQgxv9ttFrHQxyiYAhnCUYhOyJcIsboTMgRJQ4DWKVAvlUW7SZ9rEAA== X-Received: by 2002:a17:906:32cb:b0:9a5:da6c:6539 with SMTP id k11-20020a17090632cb00b009a5da6c6539mr2828567ejk.75.1694027470664; Wed, 06 Sep 2023 12:11:10 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id lt14-20020a170906fa8e00b00977eec7b7e8sm9438212ejb.68.2023.09.06.12.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:11:09 -0700 (PDT) Message-ID: <821cee7521bb4089f61e097addbb1e1ab4ed644f.camel@gmail.com> Subject: Re: How can we decrease the cognitive overhead for contributors? From: Liliana Marie Prikler To: Vagrant Cascadian , brian , "(" Cc: Katherine Cox-Buday , Simon Tournier , Maxim Cournoyer , Saku Laesvuori , Attila Lendvai , Andreas Enge , guix-devel@gnu.org Date: Wed, 06 Sep 2023 21:11:08 +0200 In-Reply-To: <87h6o7mbo2.fsf@wireframe> References: <20230827135726.y33t55w4cvq6zsvb@X-kone> <874jkift8v.fsf@gmail.com> <867cp4sj7k.fsf@gmail.com> <38242808-2f06-4674-3842-aea1a5378d05@gmail.com> <87a5u0o3z2.fsf@disroot.org> <87sf7s9oi9.fsf@spork.org> <67115f26712acbb1d83b71f4418c682a5e9762a4.camel@gmail.com> <87h6o7mbo2.fsf@wireframe> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=liliana.prikler@gmail.com; helo=mail-ej1-x641.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -7.08 X-Migadu-Queue-Id: BB1F852F9D X-Migadu-Spam-Score: -7.08 X-TUID: Ld4W6g1WQVZw Am Mittwoch, dem 06.09.2023 um 10:52 -0700 schrieb Vagrant Cascadian: > I always get tripped up with phases, modify-phases, etc. as there > seem to be potentially four or more levels deep in some common code > patterns... for example, a recent commit mentioning phases: >=20 > commit c14c25b4fb625c2a5b9512618b3eb17ff15f7e71 >=20 > =C2=A0=C2=A0=C2=A0 gnu: go-github-com-tdewolff-minify-v2: Regenerate hash= . >=20 > =C2=A0=C2=A0=C2=A0 * gnu/packages/golang.scm (go-github-com-tdewolff-mini= fy- > v2)[#:phases]: Add > =C2=A0=C2=A0=C2=A0 phase 'regenerate-hash. > ... > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index 44953d6111..3c486c4121 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -3685,11 +3685,24 @@ (define-public go-github-com-tdewolff-minify- > v2 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 > "0h006wpfkl0ls0skqxblwcanrhmphgq5q0ii26l2ayh7s99cgmy3")))) > =C2=A0=C2=A0=C2=A0=C2=A0 (build-system go-build-system) > =C2=A0=C2=A0=C2=A0=C2=A0 (arguments > -=C2=A0=C2=A0=C2=A0=C2=A0 (list #:import-path "github.com/tdewolff/minify= /v2")) > +=C2=A0=C2=A0=C2=A0=C2=A0 (list #:import-path "github.com/tdewolff/minify= /v2" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phases > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #~(modify-p= hases %standard-phases > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (add-after 'unpack 'regenerate-hash > ... >=20 > Why is it not more like: >=20 > =C2=A0=C2=A0=C2=A0 * gnu/packages/golang.scm > =C2=A0=C2=A0=C2=A0 (go-github-com-tdewolff-minify-v2)[arguments][phases][= modify- > phases]: > =C2=A0=C2=A0=C2=A0 Add 'regenerate-hash. >=20 > Honestly, that *seems* ridiculous to me, but I do not understand > *why* based on the comment above or other patterns I have observed in > the wild. For one, reusing the same pair of braces is dangerous when you actually need to split lines, which eventually, of course, you will. So don't. Use different pairs. > My inclination would be: >=20 > =C2=A0=C2=A0=C2=A0 (go-github-com-tdewolff-minify-v2)[arguments]: Add pha= se > 'regenerate-hash. >=20 > What goes in the square brackets? How many levels deep? Do I put > something in the prose of the comment or in square brackets? You can use =E2=80=98fancy quotes=E2=80=99 in ChangeLogs, which would break= scheme syntax. So=20 (go-github-com-tdewolff-minify-v2)[arguments]: Add =E2=80=98regenerate- hash=E2=80=99 phase. would be clearer than your suggestion. Why use [#:phases] then?=20 Because people understand it to be a shorthand for [arguments]<#:phases>, the most common way in which the arguments field changes. If you change both that and idk, <#:configure-flags>, you'd type them out. > I can see how really not wanting to iterate with N back-and-forth > discussions in review could hinder someone with a less flexible > schedule, especially if there are no other significant changes to the > patch... it could get demotivating. You won't get N back and forth discussions solely on the format of the ChangeLog. If it were just that, the reviewer could just write it on their own and be done with it; there's typically code changes as well involved or at the very least undocumented changes that ought to be documented. Cheers