From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +Mc2BPxtsGIKhgEAbAwnHQ (envelope-from ) for ; Mon, 20 Jun 2022 14:54:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mF9QA/xtsGJVtQAAG6o9tA (envelope-from ) for ; Mon, 20 Jun 2022 14:54:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C55CE7E2 for ; Mon, 20 Jun 2022 14:54:19 +0200 (CEST) Received: from localhost ([::1]:48884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3Gv4-0000vu-MN for larch@yhetil.org; Mon, 20 Jun 2022 08:54:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Gtw-0008AW-H7 for guix-devel@gnu.org; Mon, 20 Jun 2022 08:53:10 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:49749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Gtt-0006HJ-QH; Mon, 20 Jun 2022 08:53:07 -0400 Received: from hermia.goebel-consult.de ([79.211.180.80]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M3UhO-1o3p8849b8-000eIW; Mon, 20 Jun 2022 14:53:03 +0200 Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 14BEC5F536; Mon, 20 Jun 2022 14:53:07 +0200 (CEST) Message-ID: <81228805-564d-127f-96cc-986be9de6e00@crazy-compilers.com> Date: Mon, 20 Jun 2022 14:53:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Hartmut Goebel To: guix-devel , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <87ee07m77w.fsf@gnu.org> <87ee06g5s4.fsf@ditto.jhoto.spork.org> <87czfpilmn.fsf@gnu.org> <87ilpca4p7.fsf@gnu.org> Content-Language: en-US Organization: crazy-compilers.com Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <87ilpca4p7.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:3tTcwhrgHwZfHH9LIrF+J0/2YtxK9hQTzICRkvunLMBHLE+ebFc Qcer1lA4tn2X1tY16t8c6JTrUVSvwE+98dKBHmxVEzJjDKAiBkMxEnMxyfZXt8HI+9LvHPc DDGw7Nbasc2hmYwkLtI08dJc1nfN6DKAyNTR+mUZTluU4hfDV0ite7otMG2axyoER6GlncT R8Ck7E5Nw6cZSX/HDMm8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:IOtmV088b3A=:GhDrWDTjxgVZ9JFaicsasc JrlrfnCLUU0v1j5vHNKLQDTlD4n0z/HvBRDYiufzCFvw4iMvIWhOMwpa7CiTVga32kcNaM1B3 A0nAOym0aQLG0HaRzGK2POXi+dEknyDdypin3EsSXdk4YAfByZkppdzxVrzLgAb3DSBMSNDGC zmXc5wSDohvGdjt2g4WL9UxOqsqgUuSxdljpPM8To/s7de9LcEMgzrLWpVfMbzeNHKyPIodpy SkciJGtsdzX7tgjqI0l+IJzwkC0eSotZqgK3JCJKtWdYeRJ/taYTOyUyrNlgLxZx6SHW03BMk byedFrN6fEXL8b4ePWEF8TcOqC90+oaJWLAsc4LIR/RjRbuY1VuNKB87xUxVUcAMb7PgDb3fe Sr081iM7gVIhQ8ldItp0s/ydOHWf17mhRiD0BZhKdH7dU1Q8jeux5fWJSYwvsq7mbuXXh5prQ RP1XOHmizWQFpkT8xrHAFwuLNy45UQ0v2XwPy4jHQ44jIwHNDiVhwO3F2ZwjMO62lAuiZIkx6 jOmJM9Q/dAyXHTEkv/k8QZRBUAAWnSzmr4G1xljFLtvtW0bo3fGuhZLOiY0CwNf3Zc/RNjiCT /1wpcw7MZ7TmwTDxHOSNrOzCdODVsqnV5UCytq1/KxigXQnue/6L9UP68pcYG5N6RttgYV76c fSpFoUQRqkCV5QqBv7+vQ1Rg1QaqMShhbsIpFlVk7IHOM9g4WAwsn3IQ/zfeVRm0B5Z2CUGbr xshLtKDS+p/XtjdTdoJw13JhxJOy3sXWyT/RQx/CMftcsTeV4l9JIvymgu8= Received-SPF: none client-ip=212.227.126.187; envelope-from=h.goebel@crazy-compilers.com; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655729659; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ZofZGxrDgM4bgSFPnBJBJ+ukkhAZsFc3SBiyScv8SNI=; b=tvxQDiH6H2l+BE2GKfxy/kfWkBiqqcK6vn21Pa6n4zNnzceRevHDKPqZhmYRMMy6Bfnv8O X9WM9xb1kIc7unJwDnO75IYIxnNx3pyb4E9vzg+6MCWQemkd+M2aDtaoWWow7Wci23/dc9 4zyNtnpBzv/s0x97aLOq0uBqBtXgj/uwee0L1baXtoQnWKSOGshi4PrJA43rfIuzntbKmk QnNXkPq6in6DXZsTErboTxklSAp3rUPMPdaTrl4FqLb7NDPFNG0QubCZe8CRKPtkDgxVth goKytsi83CmiRGyYLipJX0yEeq7mn/kEwYlMecZgfiBzdlElro9WL+a+OWqjoA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655729659; a=rsa-sha256; cv=none; b=COKhXnvJIxpJDEVxgC+a6xRW3M3FYRsbD+Zaz2XktjKJz6eshGJPtmi/Uh4rwNKewTXFPd gGn0dO3/4hlHAdo/vS1IK+GO/G4Lj7l3/HhObEitzgbbnPsw/YaYKlGFJIpOlpOLROMfHa U3MKE7yAJ3oasabJxGFxXX80XTPXIxf849pQ7r+3U6nm3zZ21jCS2/5f9AheJAtKDD7oaA 1nsdPU93R/PidlPiTr3mEXz/n51+0hbTsG7x1y2ifMbCGZKZgsmkzrskkatFLOhLDROHuw qMAyqNMg5OeqqljbN92IVAVizTnEeY8VDyIeD2FZLIVg3u7qafuRSZIpxt22uQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.77 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9C55CE7E2 X-Spam-Score: -2.77 X-Migadu-Scanner: scn0.migadu.com X-TUID: 08DoMqxiizVB Hi, here are my reasons for reviewing patches very very rarely- Basically I share Brian Cully's experiences. I'm using Thunderbird for mail and my system is set up to emacs could send out mails. I tried debbugs from time to time and for me it is disgusting: * too complicated to get to the list of patches or bugs ( I never can remember the many key-presses to perform) , * I did not manage to apply patches from there (emacs would need to know where my guix development directory is - how can I tell it?) * commands withing debbugs feel complicated * if a ticket contains several updated patches, its very hard to find those relevant (one of the reasons of forges' success is that they present you the current state) * actually testing the patches required to apply the patches to my worktree - and chances are high 'git am' will fail with some conflict - chances raise extremely for old patches * Over all for me debbugs.el needs a much more "noops"-friendly interface Regarding the actual review: * Yes, I miss a review guide-line * As Arun wrote: Guix has high quality standards. I feel uncomfortable with judging whether a summary or description is good enough. Also I'm not a native speaker and don't feel entitled to review English gramar and spelling. * I miss a way to contribute to a review but not actually approving it. (In git(lab,hub) I could add comments other reviewers and the submitter could resolve or give feedback. This allows me to focus on e.g. some parts, while someone else could review the summary and description.) * I also miss automated tests. E.g. it dos not make sense to waste my time for running 'guix lint', as a automate could do this. When agreeing to a patch: * I'd like to simply merge the patch without taking care abut whether the submitter has commit right. This saves time for the submitter. Sending "LGTM" is pleasant, anyhow wasting time. The reviewer needs to send a mail, the submitter needs to dig the branch, rebase it and push. If the reviewer already did merge it, he/she could push, too, IMHO. * And for me as a submitter: I want my patches to be merged by the reviewer. Am 07.06.22 um 17:11 schrieb Ludovic Courtès: > Do you or would you use them to keep track of pending patches? I use issues.guix.gnu.org eventually. Anyhow this is browse-only. I did not even manage to add a reply there. -- Regards Hartmut Goebel | Hartmut Goebel |h.goebel@crazy-compilers.com | |www.crazy-compilers.com | compilers which you thought are impossible |