unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: guix-devel <guix-devel@gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: On commit access, patch review, and remaining healthy
Date: Mon, 20 Jun 2022 14:53:00 +0200	[thread overview]
Message-ID: <81228805-564d-127f-96cc-986be9de6e00@crazy-compilers.com> (raw)
In-Reply-To: <87ilpca4p7.fsf@gnu.org>

Hi,

here are my reasons for reviewing patches very very rarely-

Basically I share Brian Cully's experiences. I'm using Thunderbird for 
mail and my system is set up to emacs could send out mails.

I tried debbugs from time to time and for me it is disgusting:

  * too complicated to get to the list of patches or bugs ( I never can
    remember the many key-presses to perform) ,
  * I did not manage to apply patches from there (emacs would need to
    know where my guix development directory is - how can I tell it?)
  * commands withing debbugs feel complicated
  * if a ticket contains several updated patches, its very hard to find
    those relevant (one of the reasons of forges' success is that they
    present you the current state)
  * actually testing the patches required to apply the patches to my
    worktree - and chances are high 'git am' will fail with some
    conflict - chances raise extremely for old patches
  * Over all for me debbugs.el needs a much more "noops"-friendly interface

Regarding the actual review:

  * Yes, I miss a review guide-line
  * As Arun wrote: Guix has high quality standards. I feel uncomfortable
    with judging whether a summary or description is good enough. Also
    I'm not a native speaker and don't feel entitled to review English
    gramar and spelling.
  * I miss a way to contribute to a review but not actually approving
    it. (In git(lab,hub) I could add comments other reviewers and the
    submitter could resolve or give feedback. This allows me to focus on
    e.g. some parts, while someone else could review the summary and
    description.)
  * I also miss automated tests. E.g. it dos not make sense to waste my
    time for running 'guix lint', as a automate could do this.

When agreeing to a patch:

  * I'd like to simply merge the patch without taking care abut whether
    the submitter has commit right. This saves time for the submitter.
    Sending "LGTM" is pleasant, anyhow wasting time. The reviewer needs
    to send a mail, the submitter needs to dig the branch, rebase it and
    push. If the reviewer already did merge it, he/she could push, too,
    IMHO.
  * And for me as a submitter: I want my patches to be merged by the
    reviewer.


Am 07.06.22 um 17:11 schrieb Ludovic Courtès:
> Do you or would you use them to keep track of pending patches?

I use issues.guix.gnu.org eventually. Anyhow this is browse-only. I did 
not even manage to add a reply there.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          |h.goebel@crazy-compilers.com                |
|www.crazy-compilers.com  | compilers which you thought are impossible |



  parent reply	other threads:[~2022-06-20 12:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 15:10 On commit access, patch review, and remaining healthy Ludovic Courtès
2022-06-02 20:22 ` Brian Cully via Development of GNU Guix and the GNU System distribution.
2022-06-03 19:37   ` Ludovic Courtès
2022-06-03 21:17     ` Ricardo Wurmus
2022-06-07  7:08     ` Efraim Flashner
2022-06-07 15:11       ` Ludovic Courtès
2022-06-08 11:39         ` Efraim Flashner
2022-06-08 21:10           ` Ludovic Courtès
2022-06-20 12:53         ` Hartmut Goebel [this message]
2022-06-21 15:44           ` zimoun
2022-06-22  9:19             ` Munyoki Kilyungi
2022-06-02 20:32 ` Pier-Hugues Pellerin
2022-06-03 19:42   ` Ludovic Courtès
2022-06-02 21:35 ` Luis Felipe
2022-06-03  8:22   ` Feed on specific topic (public-inbox?) zimoun
2022-06-03 10:51     ` zimoun
2022-06-06 12:11 ` On commit access, patch review, and remaining healthy Arun Isaac
2022-06-06 21:43   ` Ludovic Courtès
2022-06-07  6:44     ` zimoun
2022-06-08  9:30       ` Giovanni Biscuolo
2022-06-14 12:24         ` zimoun
2022-06-15  7:01           ` Arun Isaac
2022-06-15  9:19             ` Ludovic Courtès
2022-06-19  6:55             ` Paul Jewell
2022-06-20 12:11               ` Arun Isaac
2022-06-15 15:11           ` Giovanni Biscuolo
2022-06-08 10:54     ` Giovanni Biscuolo
2022-06-09 19:55     ` Arun Isaac
2022-06-08  9:49   ` Giovanni Biscuolo
2022-06-09 19:50     ` Arun Isaac
2022-06-10 12:27       ` Giovanni Biscuolo
2022-06-10 15:03         ` Efraim Flashner
2022-06-10 16:10           ` Giovanni Biscuolo
2022-06-10 16:26           ` Giovanni Biscuolo
2022-06-10 15:03         ` Maxime Devos
2022-06-11  4:13         ` Thiago Jung Bauermann
2022-06-11  9:37           ` Ludovic Courtès
2022-06-14 11:54           ` zimoun
2022-06-14 15:54             ` Maxim Cournoyer
2022-06-15  6:46               ` Arun Isaac
2022-06-13 12:19         ` Arun Isaac
     [not found] <mailman.12124.1654864076.1231.guix-devel@gnu.org>
2022-06-12  8:18 ` Ricardo Wurmus
2022-06-12  9:42   ` Giovanni Biscuolo
2022-06-12 13:10     ` Maxime Devos
2022-06-13  9:34       ` Giovanni Biscuolo
2022-06-13 10:48         ` Maxime Devos
2022-06-13 14:21           ` Giovanni Biscuolo
2022-06-12  8:21 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81228805-564d-127f-96cc-986be9de6e00@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).