From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eMW1Am1tAGYKOwEAe85BDQ:P1 (envelope-from ) for ; Sun, 24 Mar 2024 19:14:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id eMW1Am1tAGYKOwEAe85BDQ (envelope-from ) for ; Sun, 24 Mar 2024 19:14:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lrwEgjlO; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711304045; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+NxTHsFZZwGHdTmVNpJVwRFBZeKPiTGspipnOypqd+E=; b=MMW4QoX2+x0IFtCx8Ht6vhCgoXZj3LagRaBoKA+9ueOSNvbc+34r/1Q248j+HNKb9JDF14 wwOAy9E9Dai2k4XkEcfFfF7fun/UPylLwsJddGWj4RAhdfSiKl2N47N3+fZxQMW7xfCZ+S tPGbtHsGW3t+5cwasDsr7PiHWYDw3fUPTd+rr+xlvAXiRlRQj5tueLvDFUxjuWPOaJGtUm z2Gaa8Ay1D9z/QCZUC8gNApFxer6eROMuAzWmdlLhOwhIBWFyirxekF1O2c2yQrcp6ZvFu N3ISHDmH6kYlaj76rOSuLmw5AluezekL63zX95/xQPhRw1d+u6imeu58g/bcog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lrwEgjlO; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711304045; a=rsa-sha256; cv=none; b=H9GCGjueCQ9BfOBHCrNpGXAUaDQxfWJRIduNJ7NlRSnLxfnCmEoDEwgsf24V5BC9Z/fNqV /4zMUBU9niT7gUAisTNeKwJagZOl9teAe2Dj0A6kDyz1HiZNro/6oKk7UxJ0dRxTnRaDh2 N/u5hrCseUNGLs3hnWk/VCoQn+Qy4GfRsb+feiJqVry9tLMdGudxlGSVkDrdx7lzuPaW1d dyXtzKogSp/XHiP4JUs3T6y31UvNRJN9G3uU/eNNYsL7pCf4MqRI73JVXSngibCFBcg3Ps mS4x0awDeRP08Bis8A50FolFMsmwEKmWi294qtS2+AuRnRnuqgddY/EsYGc+Nw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9924444AF for ; Sun, 24 Mar 2024 19:14:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1roSLd-0001wd-Ie; Sun, 24 Mar 2024 14:13:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roSLT-0001sh-MR for guix-devel@gnu.org; Sun, 24 Mar 2024 14:13:24 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roSLQ-000277-6X for guix-devel@gnu.org; Sun, 24 Mar 2024 14:13:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 188ED240027 for ; Sun, 24 Mar 2024 19:13:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711303998; bh=yaWjM+uKAo580wLW+ams4tvPyQ0abDAfeDI1NBVIEXg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=lrwEgjlOSRoPNN7cGyhWNQXXOI//oKxOiSCBrt8XQBQkLUXm8vu0CbVWQqU6LlVWI X7H9b6LcvjlR59bwkbsABV9MlG/b6IniI9zKvDbNq1UJRmB/YmDzVx4E984eFAnfql 1cE0yYVKZLqVwCJY7fe6NngOa6ZacsbCqQnJlBFFnKsTtyUhfFEZYoG1XzCpxoE0Or zh+ICqs0rBD/abpEM3Y9gEv0l8c1E0RJyse+EAvc0D+3rdAExWUmZlKYMYrjvLZw4V LM7zCvxgdsIC6dMNvUT4Rj4aQbaw1OZjigThjUTMslA4gONM086cz1YWyvDwhq5bVA BIqTVjMt2ehxQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V2khF39NJz6tvm; Sun, 24 Mar 2024 19:13:16 +0100 (CET) From: David Elsing To: Ricardo Wurmus Cc: guix-devel@gnu.org, ludo@gnu.org Subject: Re: PyTorch with ROCm In-Reply-To: <87le67d449.fsf@elephly.net> References: <86msqoeele.fsf@posteo.net> <87le67d449.fsf@elephly.net> Date: Sun, 24 Mar 2024 18:13:15 +0000 Message-ID: <7ybk734hxg.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=david.elsing@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -10.02 X-Migadu-Queue-Id: B9924444AF X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -10.02 X-TUID: xcmxFSrDHWYu Hi Ricardo, thanks for the information! Ricardo Wurmus writes: > Oh, commit 8429f25ecd83594e80676a67ad9c54f0d6cf3f16 added > python-pytorch2 at version 2.2.1. Do you think you could adjust your > patches to modify that one instead? I already adjusted the patches yesterday to remove the python-pytorch2 package you added, as the patch series updates the main python-pytorch package to version 2. The new inputs of your package were already included, with the exception of python-opt-einsum. I had overlooked it before and included it now. :) Is there a reason to keep version 1 around? Then I could adjust the patches again. Otherwise, it makes sense for me to move the python-pytorch package to version 2.2.1 and have a package variant with 2.0.1 for r-torch (which I kept and adjusted). Due to problems when building dependencies, the new package only succeeds to build for x86_64. As I explained in the patch series, asmjit fails on armhf because GCC runs out of memory (it reaches 4 GB I think and more is of course not possible) and cpuinfo has a known bug on aarch64 [1], which causes the tests to fail and AFAICT also break PyTorch at runtime. Through python-pytorch -> python-expecttest -> poetry -> python-keyring -> python-secretstorage -> python-cryptography, the python-pytorch package now depends on rust, which currently requires too much memory to build on 32 bit systems, so i686 is not supported either. What do you think should be done here? I added all packages required for the core tests to native-inputs, but decided to disable them as they require a long time to run. If I remove the test inputs (in particular python-expecttest), the package could probably also be built for i686. Would it be acceptable keep them as a comment for reference? > I think it is sufficient to only have the current version of ROCm; other > versions could be added if there is reasonable demand. That sounds good to me. Best, David [1] https://github.com/pytorch/cpuinfo/issues/14