From mboxrd@z Thu Jan  1 00:00:00 1970
From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
Subject: Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Date: Mon, 19 Sep 2016 20:20:26 +1000
Message-ID: <7f06586d-9d76-77de-c366-3ff7feabf313@openmailbox.org>
References: <20160914091229.GA14555@sax.terramar.selidor.net>
	<20160914091724.GG5711@sax.terramar.selidor.net>
	<20160916054637.GB14289@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brendan.tildesley@openmailbox.org>)
	id 1blvgn-0005ag-8G
	for guix-devel@gnu.org; Mon, 19 Sep 2016 06:20:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brendan.tildesley@openmailbox.org>)
	id 1blvgi-0007cL-Qr
	for guix-devel@gnu.org; Mon, 19 Sep 2016 06:20:40 -0400
Received: from smtp23.openmailbox.org ([62.4.1.57]:53641
	helo=smtp8.openmailbox.org) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brendan.tildesley@openmailbox.org>)
	id 1blvgi-0007ao-HH
	for guix-devel@gnu.org; Mon, 19 Sep 2016 06:20:36 -0400
In-Reply-To: <20160916054637.GB14289@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Leo Famulari =E6=96=BC 2016-09-16 15:46 =E5=AF=AB=E9=81=93:
> On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote:
>> Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch.
>>
>> * gnu/packages/python.scm (i3-quickswitch): New variable.
> Cool, this works :)
>
>> +(define-public i3-quickswitch
>> +  (package
>> +    (name "i3-quickswitch")
> Again, I think that we should stay closer to the upstream name, in this
> case "quickswitch-for-i3".
I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a
better solution is to ensure "i3-py" in the description or synopsis so
that `guix package -s' finds it. As for quickswitch, isn't the upstream
name also simply "quickswitch-i3"?
>> +    (build-system python-build-system)
> Also again, it would be nice to include README.rst.