From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mN42KlzL8mLXbAEAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 23:02:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yEBVKVzL8mKDJwAAG6o9tA (envelope-from ) for ; Tue, 09 Aug 2022 23:02:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 515693DCCE for ; Tue, 9 Aug 2022 23:02:20 +0200 (CEST) Received: from localhost ([::1]:46528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLVsn-0006et-LD for larch@yhetil.org; Tue, 09 Aug 2022 16:31:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLVrr-0006Sv-2z for guix-devel@gnu.org; Tue, 09 Aug 2022 16:30:33 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:59286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLVro-0000dN-MZ for guix-devel@gnu.org; Tue, 09 Aug 2022 16:30:22 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id 5YWF2800920ykKC01YWFF3; Tue, 09 Aug 2022 22:30:17 +0200 Message-ID: <77ee6166-a430-a00f-0bac-243fd940df83@telenet.be> Date: Tue, 9 Aug 2022 22:30:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] doc: Update contribution guidelines on patches, etc. Content-Language: en-US To: Liliana Marie Prikler , Guix-devel Cc: blake@reproduciblemedia.com, Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Philip McGrath References: <2fe4881ad87876ae70ef4f3340b34d589a65bb71.camel@gmail.com> <9e87d335-ed11-1bd9-fe72-9ba23ae4af63@telenet.be> <94958dc21ac67cda21530d512ee10b32b76d5d28.camel@gmail.com> <97ab139b-3d7c-1919-d51e-79f1c1eb5e33@telenet.be> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Vb7QZKlY8fp4sClc0xyRWj0Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660077017; bh=kJXhxGaRrpQRPEpbBIbRuInXO5dQli8mPLymJf+rKAM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=WkdPPyjlN5A4LzjEISc0TvyBaxomEwLAshQTa/dLIegWfOqHINlIRX/0Y/vlGLd+m wfDFCsUTOZwBaz/mv4qHaJv4/+dlhmULJbDgT+qRPJgGIEaub8wS2XM0ccv87uffYf jfCnimil7hphbVcxjKgH/Actw/GG0QLvKv6bm3lt0IYetXvcw6YDhx0oPovpGNgBYs pPknsL18XZGDm5vOcbFKawqq5hR8UcDZXkYzQBZZk5wDDy+rCKYd3pOPNAnupIGfk6 D3zLXcyO+5ddQIjt0B0GlQFtWQmBgoMp/NkNpsbN7PsvfyFjPuJ/LnguZB6KdnyBYX kvim9G8cSYa6Q== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660078940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ck+vsoxg+KiIZbZVjqoBtjVLcXUklBTKT60MXGELXGk=; b=kPwwFLOw6mrqwlP5NNABwXg7bmFfcJ130vTvb3Nps6km9SN+A8I0PJbOsTVf9dmVxVJ3FM Emrqg8mSjvmfRuIOuXX5feqZUarEnC10Ci52KZoTMQlEPvcnc0WK4UZXws/fXDLSPkOmgD gV3yPlxXvXo8E4BnOu4F2TxDpCFadh6lFmUBsizL/bVYbDu3uxnLAckGX4vVbPRspJKQBU 3L37X/13CImYroD7R/Xn/HRBelDJistd8VknlDObgHFOyYkdOtRU8BVOqdVEhFWFzsNWxD ezL8xDRlkTiPR/FldrT2StSKGUscWFpatPcNp29L+QJiUxxfS74xWI6Bp27Few== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660078940; a=rsa-sha256; cv=none; b=tdN5jWBbUPLt71dO6zZXEpsLnJgaDS5RX0oN3wYoGbXzPzMKpKNNbz/vhFZYnHptIEt73L Xi5xH2J8eh3AqkUF4Ok7E2xLc+4bi+oPFD2qJpy2xvnfHWgX4g5MJLBaR2v8oHA0LxHiF0 9Wa+JmKpAFZMLvalTb6ZGj/s+pllWgyyDX9Cbq9hq7vPdd5099MeZmmvtsmpMpfrUylQYJ oD5oLIzYwLb2m/xxyFVmJy5feRWA4NB9fMz1nQAyGsoeO3v16Hg8pMB7FlgWpR+aYgXuut FBaWIu2TKwxgsKjOpyRvdPGM+7W6Ut2Ug7Iv005ca3lr9QqXAhkaXSsyxne5Hg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=WkdPPyjl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.11 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=WkdPPyjl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 515693DCCE X-Spam-Score: 5.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: sQ9xVe3btOFH This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Vb7QZKlY8fp4sClc0xyRWj0Q Content-Type: multipart/mixed; boundary="------------ZcqsFtw0eBdJfthz0CN3PRSw"; protected-headers="v1" From: Maxime Devos To: Liliana Marie Prikler , Guix-devel Cc: blake@reproduciblemedia.com, Julien Lepiller , =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Philip McGrath Message-ID: <77ee6166-a430-a00f-0bac-243fd940df83@telenet.be> Subject: Re: [PATCH] doc: Update contribution guidelines on patches, etc. References: <2fe4881ad87876ae70ef4f3340b34d589a65bb71.camel@gmail.com> <9e87d335-ed11-1bd9-fe72-9ba23ae4af63@telenet.be> <94958dc21ac67cda21530d512ee10b32b76d5d28.camel@gmail.com> <97ab139b-3d7c-1919-d51e-79f1c1eb5e33@telenet.be> In-Reply-To: --------------ZcqsFtw0eBdJfthz0CN3PRSw Content-Type: multipart/mixed; boundary="------------EuNF0FYS5e7KjBtLRTtPB6aA" --------------EuNF0FYS5e7KjBtLRTtPB6aA Content-Type: multipart/alternative; boundary="------------zl79bKbPCtCkfbLj9tfg1UwG" --------------zl79bKbPCtCkfbLj9tfg1UwG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwOS0wOC0yMDIyIDIxOjA4LCBMaWxpYW5hIE1hcmllIFByaWtsZXIgd3JvdGU6DQo+ Pj4+IE9uIDA2LTA4LTIwMjIgMDg6NTUsIExpbGlhbmEgTWFyaWUgUHJpa2xlciB3cm90ZToN Cj4+Pj4NCj4+Pj4NCj4+Pj4+ICtJZiB5b3VyIHBhY2thZ2UgaGFzIGEgYnVnIHRoYXQgdGFr ZXMgbXVsdGlwbGUgbGluZXMgdG8gZml4LA0KPj4+PiBJIGRvbid0IHRoaW5rIHRoaXMgaXMg dHJ1ZSBmb3IgcmVwbGFjaW5nIGFsbCBpbnN0YW5jZXMgb2YgImZvbyINCj4+Pj4gYnkNCj4+ Pj4gIi9nbnUvc3RvcmUvLi4uL2Jpbi9mb28iIGluIGEgZmlsZS4NCj4+PiBTaG91bGQgaXQ/ DQo+PiBJIGRvbid0IHRoaW5rIHNvLiBEaXJlY3RseSBzdWJzdGl0dXRpbmcgYWxsIHRoZSBp bnN0YW5jZXMgaW5zdGVhZCBvZg0KPj4gZmlyc3Qgd3JpdGluZyBhIHBhdGNoIHRoYXQgZG9l cyAiZm9vIiAtPiAiQGZvb0AiIG9yIHN1Y2ggc2VlbXMNCj4+IHNpbXBsZXIgdG8gbWUuwqAg VGhpcyBtaWdodCBiZSBhIGJpdCB0b28gbml0LXBpY2t5IHRob3VnaCwgbWF5YmUgaXQncw0K Pj4gY2xlYXIgZnJvbSBjb250ZXh0IHRoYXQgdGhpcyBpcyBub3QgdGhlIGtpbmQgb2YgZml4 IG1lYW50IGJ5IHRoYXQNCj4+IGxpbmUuDQo+IEknbSBzdHJ1Z2dsaW5nIHRvIHNlZSB0aGUg aXNzdWUgaGVyZS4gIEZvciBzdGFydGVycywgaXQgZG9lc24ndCB0YWtlDQo+IG11bHRpcGxl IGxpbmVzIHRvIGVtYmVkIGEgc3RvcmUgcGF0aCwgdGhlIGNoYW5nZSB1c3VhbGx5IGhhcHBl bnMgb24gYQ0KPiBzaW5nbGUgbGluZS4gIE9mIGNvdXJzZSwgdHJhbnNsYXRpbmcgdGhpcyBp bnRvIGEgc3Vic3RpdHV0ZSosIHlvdQ0KPiBleHBhbmQgdGhpcyBzaW5nbGUgbGluZSBpbnRv IG11bHRpcGxlIG9uZXMsIGJ1dCB0aGF0J3Mgbm90IHdoYXQgaXMNCj4gbWVhbnQgaGVyZS4N Cg0KSSB3YXMgdGhpbmtpbmcgb2YgZmlsZXMgdGhhdCBjb250YWluIG11bHRpcGxlIGluc3Rh bmNlcyBvZiAiZm9vIiANCih1c3VhbGx5IG9uIG11bHRpcGxlIGxpbmVzKSB0byBiZSByZXBs YWNlZCBieSAiL2dudS9zdG9yZS8uLi4vYmluL2ZvbyIsIA0Kbm90IGZpbGVzIHdlcmUgYSAi Zm9vDQpiYXIiIHdhcyBicm9rZW4gb3ZlciBtdWx0aXBsZSBsaW5lcyBhbmQgaXQgbmVlZHMg dG8gYmUgcmVwbGFjZWQgYnkgDQoiL2dudS9zdG9yZS8uLi4vYmluL2Zvbw0KYmFyIi4NCg0K QXQgbGVhc3QgZm9yIHRoZSBmb3JtZXIsIEkgZG9uJ3QgdGhpbmsgYW4gaW50ZXJtZWRpYXRl ICJAZm9vQCIgaXMgdXNlZnVsIA0KKHdpdGggc29tZSBleGNlcHRpb25zLCB3aGVuIGEgcGF0 dGVybiBtYXRjaCB3b3VsZCBjYXRjaCB0b28gbXVjaCkuDQoNClRoZSBsYXR0ZXIgY291bGQg aW4gcHJpbmNpcGxlIGhhcHBlbiwgYnV0IGl0IGRvZXNuJ3Qgc2VlbSB0byBoYXBwZW4gaW4g DQpwcmFjdGljZS4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0KDQo= --------------zl79bKbPCtCkfbLj9tfg1UwG Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 09-08-2022 21:08, Liliana Marie Prikler wrote:
On 06-08-2022 08:55, L=
iliana Marie Prikler wrote:


+If your package has=
 a bug that takes multiple lines to fix,
I don't think this is =
true for replacing all instances of "foo"
by=20
"/gnu/store=
/.../bin/foo" in a file.
Should it?
I don't think so. Directly=
 substituting all the instances instead of
first writing a patch that does "foo" -> "@foo@" or such seems
simpler to me.=C2=A0 This might be a bit too nit-picky though, maybe it's=

clear from context that this is not the kind of fix meant by that
line.
I'm struggling to see the is=
sue here.  For starters, it doesn't take
multiple lines to embed a store path, the change usually happens on a
single line.  Of course, translating this into a substitute*, you
expand this single line into multiple ones, but that's not what is
meant here.

I was thinking of files that contain multiple instances of "foo" (usually on multiple lines) to be replaced by "/gnu/store/.../bin/foo", not files were a "foo
bar" was broken over multiple lines and it needs to be replaced by "/gnu/store/.../bin/foo
bar".

At least for the former, I don't think an intermediate "@foo@" is useful (with some exceptions, when a pattern match would catch too much).

The latter could in principle happen, but it doesn't seem to happen in practice.

Greetings,
Maxime.

--------------zl79bKbPCtCkfbLj9tfg1UwG-- --------------EuNF0FYS5e7KjBtLRTtPB6aA Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------EuNF0FYS5e7KjBtLRTtPB6aA-- --------------ZcqsFtw0eBdJfthz0CN3PRSw-- --------------Vb7QZKlY8fp4sClc0xyRWj0Q Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvLD1wUDAAAAAAAKCRBJ4+4iGRcl7lJd AQCsuyqZYcpeRQyN54WReqdbmCuA5nzjCuYhaRYXY6AcEQD/ZgXJVhSQtbe/ppcoGYEnwKWJ4F5a +eLI1JjUi1wdXAQ= =2YBt -----END PGP SIGNATURE----- --------------Vb7QZKlY8fp4sClc0xyRWj0Q--