From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Vollmert Subject: Re: having trouble modifying guix-daemon Date: Mon, 8 Jul 2019 09:44:00 +0200 Message-ID: <740DC0A7-3AC0-4480-9744-AA7EC5E734CD@vllmrt.net> References: <871rzfxcs4.fsf@gnu.org> <28B65776-E327-4540-B5DA-A9B6F5C34BEC@vllmrt.net> <87ef3aoxqe.fsf@gnu.org> <87v9wggnvh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:49515) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkOJs-0001ap-Bp for guix-devel@gnu.org; Mon, 08 Jul 2019 03:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkOJr-0004Wa-8F for guix-devel@gnu.org; Mon, 08 Jul 2019 03:44:16 -0400 In-Reply-To: <87v9wggnvh.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org On 5. Jul 2019, at 23:41, Ludovic Court=C3=A8s wrote: > Robert Vollmert skribis: >=20 >>> On 1. Jul 2019, at 12:28, Ludovic Court=C3=A8s wrote: >>>=20 >>> Hello, >>>=20 >>> Robert Vollmert skribis: >>>=20 >>>> I=E2=80=99d like to improve the debug output here more generally: = At (high enough) >>>> debug level, it seems to make sense to log every operation. What = I=E2=80=99m unclear >>>> on here is whether it=E2=80=99s better to do that client or server = side, what do you >>>> think? The spots would be >>>>=20 >>>> (a) nix/nix-daemon/nix-daemon.cc:performOp (inside each = start/stopWork pair) >>>> (b) guix/store.scm:operation (next to record-operation) >>>>=20 >>>> I have a slight preference for (b) since it avoids the sending data = back >>>> and forth. >>>=20 >>> In my experience I rarely need to log every operation (e.g., every = RPC), >>> and when I do, I add a well-placed =E2=80=98pk=E2=80=99. :-) >>=20 >> That=E2=80=99s hardly something you=E2=80=99d expect a guix system = user to do that=E2=80=99s trying >> to understand why guix pull is taking forever though, is it? >=20 > No, but I don=E2=80=99t expect users to profile Guix anyway. >=20 > I didn=E2=80=99t understand your request had to do with =E2=80=98guix = pull=E2=80=99. It =E2=80=9Ctakes > forever=E2=80=9D for two reasons: I think I didn=E2=80=99t really get my point across. I didn=E2=80=99t = mean to ask about why =E2=80=98guix pull=E2=80=99 is slow (though I am interested, and am = thankful for the explanation). Instead, I=E2=80=99d like to improve on my experience, which I=E2=80=99m = sure others would run into: - working with guix, doing some calls to guix pull, guix system = reconfigure. - notice that it takes quite a while, and often hangs for extended = periods of time without clear indication what it=E2=80=99s doing, whether it=E2=80=99= s even doing anything - look through the manuals to find out how to get more useful output to = answer those questions, learn about =E2=80=9Cdebug=E2=80=9D and =E2=80=9Cverbose=E2= =80=9D command line options. - through trial and error, learn that =E2=80=9Cverbose=E2=80=9D = doesn=E2=80=99t seem to be helpful, but =E2=80=9Cdebug=E2=80=9D does add some output - but that output is mostly just pages and pages of identical = locking/unlocking the store lines In my opinion, the debug output, if available, should help to answer the = original questions. And certainly not prompt more questions, such as =E2=80=9Cis = this just spinning on a lock?=E2=80=9D which have an easy answer. To that extent, I=E2=80=99d like to improve the output of debug level = guix pull logging. If you=E2=80=99d really not like adding more debug statements, I=E2=80=99d= suggest kicking out the existing locking statements from guix daemon. Cheers Robert