From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sahithi Yarlagadda Subject: Re: Submitting Patch for r-dyn Description for cran Package Date: Tue, 20 Mar 2018 07:19:03 +0530 Message-ID: <7284174d-616a-c5c2-a1ed-a1e6d07d8178@swecha.net> References: <87tvtbd9d6.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey6Op-00059y-68 for guix-devel@gnu.org; Mon, 19 Mar 2018 21:49:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey6Ol-0002C3-7n for guix-devel@gnu.org; Mon, 19 Mar 2018 21:49:15 -0400 Received: from swecha.net ([136.243.177.181]:57083) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ey6Ok-00029N-Tq for guix-devel@gnu.org; Mon, 19 Mar 2018 21:49:11 -0400 In-Reply-To: <87tvtbd9d6.fsf@elephly.net> Content-Language: en-US List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Hi On Tuesday 20 March 2018 03:20 AM, Ricardo Wurmus wrote: > Hi, > > thank you for your contribution! > > Unfortunately, your email was way too big for me to even open :) Could > you please resend it with only the relevant changes? The changes to the > “.po” files should not be part of the patch. Oops! I have built the package and then sent the patch. Ill make a patch from the source changes and send it. This is what i did 1) Downloaded Source 2) setup environment 3) ./bootstrap, ./configure, ./make 4) then made changes to .scm file in /gnu/packages 5) built using ./pre-inst-env guix build r-dyn 6) git link 7) then did the patch. > Let’s take a closer look at the R package you’ve added. > >> +(define-public r-dyn >> + (package >> + (name "r-dyn") >> + (version "0.2-9.6") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (cran-uri "dyn" version)) >> + (sha256 >> + (base32 >> + "16fqv9k7yxdgybwzafjkyqm16qpgqz13lcjpi6a1nc8xbzlzh0gb")))) >> + (build-system r-build-system) >> + (propagated-inputs >> + `(("r-zoo" ,r-zoo))) >> + (home-page "https://cran.r-project.org/web/packages/dyn") >> + (synopsis "Time Series Regression") > Please make all worlds except for the first lowercase. > >> + (description >> + "Time series regression. The dyn class interfaces ts, irts(), zoo() and >> +zooreg() time series classes to lm(), glm(), loess(), quantreg::rq(), MASS::rlm(), >> + MCMCpack::MCMCregress(), quantreg::rq(), randomForest::randomForest() and other >> + regression functions allowing those functions to be used with time series including >> +specifications that may contain lags, diffs and missing values.") > The first sentence is just a sentence fragment. Could you please turn > it into a full sentence? > > Please leave two spaces between sentences. > > The functions that are mentioned in the description should be wrapped in > @code{…} syntax. > > Have you tried building this package? (I have not.) Yes it was successfully built and was stored in /gnu/store/......... > > Please also add a copyright line to the very top of the file. > > One more thing: in Guix we follow certain conventions when it comes to > commit messages. You can take a look at previous commit messages (with > “git log”) to see examples. > > In this case the message would look like this: > > --8<---------------cut here---------------start------------->8--- > gnu: Add r-dyn. > > * gnu/packages/cran.scm (r-dyn): New variable. > --8<---------------cut here---------------end--------------->8--- > > Would you like to send an updated version of your patch? > > Thanks again for giving this a try! > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > -- Regards Sahithi