From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sHByHF/ki2IfFwEAbAwnHQ (envelope-from ) for ; Mon, 23 May 2022 21:45:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8Nx6HF/ki2ITawEAauVa8A (envelope-from ) for ; Mon, 23 May 2022 21:45:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34A3C19F6F for ; Mon, 23 May 2022 21:45:35 +0200 (CEST) Received: from localhost ([::1]:34964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntDzi-00039n-2m for larch@yhetil.org; Mon, 23 May 2022 15:45:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntDyx-0002by-I8 for guix-devel@gnu.org; Mon, 23 May 2022 15:44:48 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:40741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntDyv-0003ew-LK; Mon, 23 May 2022 15:44:47 -0400 Received: (Authenticated sender: allan@adair.no) by mail.gandi.net (Postfix) with ESMTPSA id 2EA006000A; Mon, 23 May 2022 19:44:37 +0000 (UTC) Message-ID: <7004ca7f3be80a38fd1631cb16bd5bd2adac5a0e.camel@adair.no> Subject: Re: libvirt: A potential problem in the package and looking for guidance From: Allan Adair To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: guix-devel In-Reply-To: <8735h046bc.fsf@gnu.org> References: <8881f77c80bbc6fc4950ed64e2aef77f5a32c16f.camel@adair.no> <8735h046bc.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 23 May 2022 21:44:23 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.42.1 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2001:4b98:dc4:8::223; envelope-from=allan@adair.no; helo=relay3-d.mail.gandi.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653335135; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=u2Pzvv+6GSA9yw2XaKC0IX15duGQVuxS0Y/qWKOQuIU=; b=TTRRsxbCSNTGq2kJJ2l+2USf0IEjQBElXl/EmrEi3pQdHzCUJ+HrJZT8MILxH8CoRKPDA+ K/xaoYSfD5eQBZA4y1a6qFOVh2RBBmIb+nI/tnJPvuTEDjI7X9fT8m5+Tjc1/vYbHxTGvk VN2m3sctbSHnnZI2sDxXWkZ2F6tCPUBiDaFpYo/YsxOMhPZG4ribGxdBwkIVhQtwMpkt6F 7GRuvotwH9haGyVGctSyDiWDIimVIDhiG2APJ6dme9Gspur9+FLK4Bh+Rm8JqGQ7VjU5sK eIOrt0tTk93AJiDBG0AVwNRoAnauCm8yhvarSYmfnZnYK3eEp4LWiq9ZLEZI2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653335135; a=rsa-sha256; cv=none; b=Cz8H5xK/dMwGv8QpPCc8qxvp6yMI6TBKNRoKH5LCjGJ1GMGoV9i9wEtgEAxHJQNy0uH72O PXgdX07A2SfpdMs8THsot4bP4F8jCjoBDNtXY7AtrcWvn85YAGQ+xa8OLrCruQXb2b9uLt rzDtckY1TJ/aoL1Xr92MaQSW+gwLAIXX/OECYKX3KSEkRpR8VSC6L8i7HbqaF1eWrbmDu7 EEcI6HMmtciH0bqOVHzjEYrI6wGAgOp/YU38M+jDsSK7OBnomTqE9FMkUu6c9mE8PbErfJ qKq7gcfvpWvWuaOJT+1Z5wYy6tT9tqssbag22/4Kbfak89R5hoigZYrD03QV8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 34A3C19F6F X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: SKZx0HieHv/A Thanks! Looks like I was on a good track. The only reference that I could find to /usr/libexec/qemu-bridge-helper was in the meson.build file of the libvirt package. I wrote a package variant that looks like this, to test: (define-public libvirt-with-qemu-bridge-helper (package (inherit libvirt) (name "libvirt-with-qemu-bridge-helper") (arguments (substitute-keyword-arguments (package-arguments libvirt) ((#:phases phases) #~(modify-phases #$phases ;; libvirt needs to be able to find qemu's bridge helper ;; this is hacky, perhaps a patch on meson.build would be better. (add-after 'unpack 'find-qemu-bridge-helper (lambda* (#:key inputs #:allow-other-keys) (let* ((qemu (assoc-ref inputs "qemu"))) (substitute* "meson.build" (("/usr/libexec/qemu-bridge-helper") (format #f "~a/libexec/qemu-bridge-helper" qemu)))))))))) (inputs (modify-inputs (package-inputs libvirt) (append qemu))))) However the effort was fruitless, and my efforts on this are currently on pause. If I am able to fix it I plan to submit a patch.