unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Allan Adair <allan@adair.no>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: libvirt: A potential problem in the package and looking for guidance
Date: Mon, 23 May 2022 21:44:23 +0200	[thread overview]
Message-ID: <7004ca7f3be80a38fd1631cb16bd5bd2adac5a0e.camel@adair.no> (raw)
In-Reply-To: <8735h046bc.fsf@gnu.org>

Thanks! Looks like I was on a good track. The only reference that I could
find to /usr/libexec/qemu-bridge-helper was in the meson.build file of the
libvirt package. I wrote a package variant that looks like this, to test:

(define-public libvirt-with-qemu-bridge-helper
  (package
    (inherit libvirt)
    (name "libvirt-with-qemu-bridge-helper")
    (arguments
     (substitute-keyword-arguments (package-arguments libvirt)
       ((#:phases phases)
	#~(modify-phases #$phases
	    ;; libvirt needs to be able to find qemu's bridge helper
	    ;; this is hacky, perhaps a patch on meson.build would be
better.
	    (add-after 'unpack 'find-qemu-bridge-helper
	      (lambda* (#:key inputs #:allow-other-keys)
		(let* ((qemu (assoc-ref inputs "qemu")))
		  (substitute* "meson.build"
		    (("/usr/libexec/qemu-bridge-helper")
		     (format #f "~a/libexec/qemu-bridge-helper"
qemu))))))))))
    (inputs
     (modify-inputs (package-inputs libvirt)
		    (append qemu)))))

However the effort was fruitless, and my efforts on this are currently on
pause. If I am able to fix it I plan to submit a patch.


  parent reply	other threads:[~2022-05-23 19:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 11:43 libvirt: A potential problem in the package and looking for guidance Allan Adair
2022-05-23 15:28 ` Ludovic Courtès
2022-05-23 16:06   ` Maxime Devos
2022-05-23 19:44   ` Allan Adair [this message]
2022-05-23 20:35     ` Maxime Devos
  -- strict thread matches above, loose matches on Subject: below --
2022-05-20 15:50 Rene Saavedra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7004ca7f3be80a38fd1631cb16bd5bd2adac5a0e.camel@adair.no \
    --to=allan@adair.no \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).