From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Becze Subject: Re: (not) testing Rust packages?! Date: Sat, 25 Jan 2020 12:45:46 -0500 Message-ID: <6e429473-5e4e-503e-fdb8-6e2b65a819f9@riseup.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44749) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivPVx-0000fv-7C for guix-devel@gnu.org; Sat, 25 Jan 2020 12:46:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivPVv-0003xU-Vy for guix-devel@gnu.org; Sat, 25 Jan 2020 12:46:32 -0500 Received: from mx1.riseup.net ([198.252.153.129]:40084) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivPVv-0003uV-Kf for guix-devel@gnu.org; Sat, 25 Jan 2020 12:46:31 -0500 In-Reply-To: Content-Language: en-US List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: John Soo Cc: guix-devel@gnu.org On 1/25/20 11:46 AM, John Soo wrote: > Hi Hartmut and Martin, >=20 > I think it makes sense to run tests now. >=20 >> Part of the reason is that bringing tests for a given library can brin= g in a massive amount of dependencies. >=20 > I think that we are getting close to having complete dependencies for m= ost rust packages we have and most are declared in the package definition= . Yeah really good point there (and good work on getting all those pkgs in!= ) > Furthermore since most rust libraries we have are not executables, we c= ould still skip the build and run the tests I think. Aren=E2=80=99t the t= wo phases completely separate for cargo? Yes, will can skip the build and just test in the (cargo-build-system)=20 but `cargo test` will cause most everything to build anyways i believe. > I like the idea of having tests, too. Plus I=E2=80=99d like to see the= cargo build system come closer to the standard package definition. agreed!