From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GA0WKURK6mRCmAAAG6o9tA:P1 (envelope-from ) for ; Sat, 26 Aug 2023 20:53:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GA0WKURK6mRCmAAAG6o9tA (envelope-from ) for ; Sat, 26 Aug 2023 20:53:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8298C59675 for ; Sat, 26 Aug 2023 20:53:56 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dKrIaMIJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693076036; a=rsa-sha256; cv=none; b=QRcScuA9RaYDBrtyjAt6dFxRbrM1G6OP2+Xa6D26SlunNx4boZEEfrfUdF1OmjowUD7V0s hPn+JZYrKoAIbJ/oQ/Ax24wxzL7V8osNWvJE/ph0yTokQ6tphC6bvvbWtF84/I8lxv2dvE 2prk9fCLVgpfN81xng1DCm8Wpf9l6bN4gAEbdrwZ9PwC9dD3Yh0w451WiQnexmGh8+cQtN AOt1riEW827kI5e6pOrPWFwSDkTe6p/RV7gdzpmuq1M2k+rg9Qxnx93wMhP17B2LU/+Qsk S7EM0rvomEZvyeuhIjjjfolt8HK61dj6/0zUZpDxlf5UF1gh7+gKI2O6A2Uhsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dKrIaMIJ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693076036; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Zvj3W2tABmdLS0G3rxZjYO86celC4U/farhNRter6OY=; b=DYF+rfVEzk6JufXbStD6ACLpU7yqyED+W6mWwBvaXdQUboVBRlA5tOxPZeLZ1oHU/5odqY Tf4FO/fL4XWJpxKsrP1wtsHLBMpIEHZfLd5N9ckqsKDEXvWU+/RoO+kPdl0iE6G8b/s8YY qIjl+je/YKt0XKRWWeOpAwlDZbI5JzcZSteyiQi1SOn/ntsEJ3tsCblYb6nwcQM+3edRUu pVB9wRZh68fe/ep49dZ6SngzrH5Jv3LCodq68q/BVlSduaEA30WgB5wkylEC5Wk7p829Je Lv0Fd16JWGiO6UsgO63cks3ZpSm21N6Ie4alOiYApap4Jmb2E9PfZWyP9PkmOA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZyPb-0002r2-0D; Sat, 26 Aug 2023 14:53:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZyPZ-0002qS-D7 for guix-devel@gnu.org; Sat, 26 Aug 2023 14:53:29 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZyPW-0006cZ-CU for guix-devel@gnu.org; Sat, 26 Aug 2023 14:53:29 -0400 Received: by mail-ed1-x544.google.com with SMTP id 4fb4d7f45d1cf-52a1132b685so2885169a12.1 for ; Sat, 26 Aug 2023 11:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693076004; x=1693680804; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Zvj3W2tABmdLS0G3rxZjYO86celC4U/farhNRter6OY=; b=dKrIaMIJHTlE+wPq9lmBii72+lr1aibquHzxBx/VzhXo90kfzje0CArXXhblBlV+gX t8M5oo45tPJzbwlitsA68oU2yxEIlEgS1mwyqcBLHnxiGoBWbtGL5wHWK18ZxF3F6agt W5Ar0d74RJYo8rtcrvN4W3c3ctOGpXvR4dsI/7hqXf9AVirMoRWt2i0NxuKYfpY8oeY6 XJTkOk1GrtBiUKIXCldpFB1zroHP6bBDJB6Sisc/bnEuywuoSLkgSC8KCMRcYav+lQua 1efGpPMIAHKJXuLVyrFBYLrdZpz9gZbosyzsaTWd1fZVKxjkDRxR/q4zknOyR1RojWBH S32Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693076004; x=1693680804; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Zvj3W2tABmdLS0G3rxZjYO86celC4U/farhNRter6OY=; b=NX/SQtTfYwkFHK1CmXUnPJxy0nBHQoy+vDyeLdWtWIxyARsGa5KsXGwFAN4wrH7jk7 pLMV2FEuivyf4XEwvRBHcM6Z34JuLitEcYin5QEYiPhe6sQVMl3J/BlrYafuk9qeY6A1 wtP4YhP1WDYhbd4lxxIlkZG6wDqilje1UQE1Vyln7cc5dMXnWJWj16RQUYrULqePYoRB pfptRyf9NdACoWDZY9fIcm5J0NM6Ex/6pV8kaSQ2631UQ8n0l+H5xG9NfDg30c5xsE5K fLIF3acYcBjvFLBPGGpBHZOZYnupmi6T2IbVyMctp/cbRyAKMnIgtJcWVPO04bwY1xFG kuHg== X-Gm-Message-State: AOJu0YwWvOnmd1MdDi+GnEAah3J4TchV1/hkO27j9VQEepFNXkNEJSYw sfyYqBxeKa0wF7PUA/cImhY= X-Google-Smtp-Source: AGHT+IElQDoKUmAMP2xxHP4aT+8zYQtDb4S55uN3sRZWaB8A1CgCh9FPDtfYoLQ5pLaCS+0jAv2mwg== X-Received: by 2002:a17:906:5392:b0:9a1:debe:6b9b with SMTP id g18-20020a170906539200b009a1debe6b9bmr8344972ejo.35.1693076004234; Sat, 26 Aug 2023 11:53:24 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id q4-20020a170906144400b00992f81122e1sm2499871ejc.21.2023.08.26.11.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Aug 2023 11:53:23 -0700 (PDT) Message-ID: <689763be71c2c1d8f7222da20cc219aa529336c2.camel@gmail.com> Subject: Re: How can we decrease the cognitive overhead for contributors? From: Liliana Marie Prikler To: kiasoc5@disroot.org, Attila Lendvai Cc: Wilko Meyer , Katherine Cox-Buday , guix-devel@gnu.org Date: Sat, 26 Aug 2023 20:53:20 +0200 In-Reply-To: <0e88ad722f88591d5e79da9793a2a64e@disroot.org> References: <8735084vv2.fsf@wmeyer.eu> <0e88ad722f88591d5e79da9793a2a64e@disroot.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::544; envelope-from=liliana.prikler@gmail.com; helo=mail-ed1-x544.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -7.09 X-Migadu-Queue-Id: 8298C59675 X-Migadu-Spam-Score: -7.09 X-TUID: L4PyoFDjaPiK Hi kiasoc5, hi Attila Am Samstag, dem 26.08.2023 um 19:42 +0200 schrieb kiasoc5@disroot.org: > On 2023-08-25 11:31, Attila Lendvai wrote: > > > I feel like the advantages of a email-based workflow nowadays is > > > more on the maintainer side of things (as managing large projects > > > is easier > >=20 > >=20 > > another thing worth pointing out here is that the harder it is to > > test a submitted patchset locally, the fewer non-committer reviews > > will happen. > >=20 > > and if all the review work rests on the shoulders of the > > committers, then there'll be long response times on submissions, or > > straight out forgotten/ignored submissions (khm). especially if > > it's about some hw or some sw that none of the committers care > > about, or could test locally (e.g. Trezor support: > > https://issues.guix.gnu.org/65037=C2=A0that=20 > > doesn't even build in master). Do you mean that Trezor doesn't currently build on master or that this series doesn't build relative to master any longer? It'd be quite weird if it was the latter, but oh well. I'll review the series afterwards. > I would like to hear from committers if non-committer reviews are=20 > helpful, because I don't really know how or what I can comment on for > incoming patches on packages I'm not really familiar with. If you're not familiar with the package, on which grounds would you review the patch? This holds for committers and non-committers all the same; it's a main reason as to why I don't review many Emacs packages despite being in the Emacs team. My init.el is on the smaller side and only exercises a small portion of the emacs-xyz module. On the other hand, if you do have relevant information to add, please do so. For instance, if you know about the hardware or the software or even if you've only heard about some anti-feature such as telemetry, such information is valuable. If you want to nerd about the way we write ChangeLogs, that's also fine, and might save someone else the need to do so (or encourage them to do so as well, you win some, you lose some). > Also do "this builds and works locally" comments help? "Builds locally" not so much, unless it's a package that CI doesn't handle usually. "Works locally" should be qualified to distinguish it from simply "builds locally", but if you say something along the lines of "I've tested and ran the program; it works as I'd expect", you might be saving a committer some time and allow them to focus on other things. If there are no cosmetic flaws and the committers are aware that the package works fine for more than just a single person, they can fast track it more easily. OTOH, if you write "works locally" and no committer reads it =E2=80=93 for any reason, really =E2=80=93 the result= will be the same as if you never wrote it. TL;DR: "Builds locally" helps maybe, but probably not. "Works locally" probably helps, but sometimes not. For cases in which "works locally" doesn't seem to help, you sadly have to check the CCs and add a committer who might look like they'd be interested in upstreaming the series :( Cheers