From: Bruno Victal <mirai@makinata.eu>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>, cox.katherine.e@gmail.com
Subject: Re: [RFC] Cosmetic changes to define-configuration usage
Date: Mon, 3 Apr 2023 15:13:02 +0100 [thread overview]
Message-ID: <66232cd3-ff0b-e248-1ae0-4839e793e994@makinata.eu> (raw)
In-Reply-To: <87lejdvuzn.fsf@gmail.com>
On 2023-03-31 15:46, Maxim Cournoyer wrote:> I have some apprehension that if we start adding white space between the
> fields here, we'll soon have people adding white space to many other
> places (for consistency or other reasons), which I wouldn't welcome (I
> value compactness, and since in Scheme a single newline is used to
> delimit things at the top level, too much of white space can make things
> less readable in my opinion).
I don't think it needs to be an all-or-nothing situation,
the spacing rules can be always applied selectively “when it makes sense”.
I think spaces between fields is consistent with the general way of things,
for instance, throughout Guix, sections that are only scheme code often do
have some spaces here and there that were added without any adherence to some
rigid criteria but the programmer found it to be an adequate point to
partition the logic.
The same reasoning applies here, the logic partitioning is done per field instead.
Objectively, there's also a small quantitative difference that's not commonly
present in the rest of the codebase. define-configuration handles both code and documentation,
or putting it another way, it intersperses code and (rather long) strings. The result
is that it's particularly information-dense compared to any other part of the guix codebase.
My 2¢!
Cheers,
Bruno
next prev parent reply other threads:[~2023-04-03 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 12:33 [RFC] Cosmetic changes to define-configuration usage Bruno Victal
2023-03-28 16:20 ` Katherine Cox-Buday
2023-03-31 14:46 ` Maxim Cournoyer
2023-04-03 14:13 ` Bruno Victal [this message]
2023-04-08 19:55 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66232cd3-ff0b-e248-1ae0-4839e793e994@makinata.eu \
--to=mirai@makinata.eu \
--cc=cox.katherine.e@gmail.com \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).