unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [PATCH] gnu: Add lmms
@ 2017-03-09  4:47 Rodger Fox
  2017-03-15 22:03 ` Leo Famulari
  2017-03-21 19:39 ` Leo Famulari
  0 siblings, 2 replies; 11+ messages in thread
From: Rodger Fox @ 2017-03-09  4:47 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Sorry for the delay. I got the rpath issue fixed on this.
It should be ready to apply now.

-Rodger Fox

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-lmms.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-lmms.patch, Size: 2912 bytes --]

From 70f155cd4bde3060b87c0834f12f71886c1e0f3f Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylakoid@openmailbox.org>
Date: Wed, 8 Mar 2017 20:28:10 -0800
Subject: [PATCH] gnu: Add lmms.

* gnu/packages/music.scm (lmms): New variable.
---
 gnu/packages/music.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 87b6d5b9b..07f30cfdd 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylakoid@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2820,3 +2821,55 @@ collections and wantlists, inventory, and orders.")
 conversions between time and pulses, tempo map handling and more.  The only dependencies
 are a C compiler and glib.  Full API documentation and examples are included.")
     (license license:bsd-2)))
+
+(define-public lmms
+  (package
+    (name "lmms")
+    (version "1.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/LMMS/lmms/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; no tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-before
+          'configure 'set-ldflags
+          (lambda* (#:key outputs #:allow-other-keys)
+            (setenv "LDFLAGS"
+                    (string-append
+                     "-Wl,-rpath=\""
+                     (assoc-ref outputs "out") "/lib/lmms"
+                     ":"
+                     (assoc-ref outputs "out") "/lib/lmms/ladspa"
+                     "\"")))))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("sdl" ,sdl)
+       ("qt" ,qt-4)
+       ("fltk" ,fltk)
+       ("libogg" ,libogg)
+       ("libsamplerate" ,libsamplerate)
+       ("fluidsynth" ,fluidsynth)
+       ("libvorbis" ,libvorbis)
+       ("alsa-lib" ,alsa-lib)
+       ("portaudio" ,portaudio)
+       ("ladspa" ,ladspa)
+       ("libsndfile1" ,libsndfile)
+       ("libxft" ,libxft)
+       ("freetype2" ,freetype)
+       ("fftw3f" ,fftwf)))
+    (home-page "https://lmms.io/")
+    (synopsis "Music composition tool")
+    (description "LMMS is a digital audio workstation.  It includes tools for sequencing
+melodies and beats and for mixing and arranging songs.  LMMS includes instruments based on
+audio samples and various soft sythesizers.  It can receive input from a MIDI keyboard.")
+    (license license:gpl2+)))
-- 
2.12.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] gnu: Add lmms
@ 2017-02-23 18:13 Rodger Fox
  2017-02-24 10:56 ` Julien Lepiller
  0 siblings, 1 reply; 11+ messages in thread
From: Rodger Fox @ 2017-02-23 18:13 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

>  It's a good idea to run "./pre-inst-env guix lint PACKAGENAME" which
>  will pick up long lines for example.
>  I have a ruler/colored line at character 83 in vim, but I'm not yet
>  ready with the setup to write correct code again in vim. There's
>  a similar thing for emacs.
> 
>  I would replace the third or second "It" with @code{LMMS} or simply
>  LMMS.

Thanks for pointing that out. I missed that pre-inst-env tool in
the manual until you just mentioned it here. That helps a lot.
My corrected patch is attached. It passes the linter this time.

-Rodger Fox

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-lmms.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-lmms.patch, Size: 2636 bytes --]

From a40d4032431d5a22809c25d81ecdc8ed370e989c Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylakoid@openmailbox.org>
Date: Wed, 22 Feb 2017 15:08:30 -0800
Subject: [PATCH] gnu: Add lmms.

* gnu/packages/music.scm (lmms): New variable.
---
 gnu/packages/music.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 730d981e6..fe24c94f6 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylakoid@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2818,3 +2819,45 @@ collections and wantlists, inventory, and orders.")
 conversions between time and pulses, tempo map handling and more.  The only dependencies
 are a C compiler and glib.  Full API documentation and examples are included.")
     (license license:bsd-2)))
+
+(define-public lmms
+  (package
+    (name "lmms")
+    (version "1.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/LMMS/lmms/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f              ; No tests to run.
+       #:validate-runpath? #f)) ; Binaries in subdirectories of /lib are dependent.
+                                ; It fails the runpath validation, but still works.
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("sdl" ,sdl)
+       ("qt" ,qt-4)
+       ("fltk" ,fltk)
+       ("libogg" ,libogg)
+       ("libsamplerate" ,libsamplerate)
+       ("fluidsynth" ,fluidsynth)
+       ("libvorbis" ,libvorbis)
+       ("alsa-lib" ,alsa-lib)
+       ("portaudio" ,portaudio)
+       ("ladspa" ,ladspa)
+       ("libsndfile1" ,libsndfile)
+       ("libxft" ,libxft)
+       ("freetype2" ,freetype)
+       ("fftw3f" ,fftwf)))
+    (home-page "https://lmms.io/")
+    (synopsis "Music composition tool")
+    (description "LMMS is a digital audio workstation.  It includes tools for sequencing
+melodies and beats and for mixing and arranging songs.  LMMS includes instruments based on
+audio samples and various soft sythesizers.  It can receive input from a MIDI keyboard.")
+    (license license:gpl2+)))
-- 
2.11.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
[parent not found: <mailman.54228.1487857637.22740.guix-devel@gnu.org>]
* [PATCH] gnu: Add lmms
@ 2017-02-22 23:18 Rodger Fox
  2017-02-23  9:15 ` julien lepiller
  0 siblings, 1 reply; 11+ messages in thread
From: Rodger Fox @ 2017-02-22 23:18 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

Here is another package. I think I got the commit message right this 
time. Let me know if I missed anything.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-lmms.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-lmms.patch, Size: 2415 bytes --]

From 8e2757bee584f4686e02da512662fb512b05c037 Mon Sep 17 00:00:00 2001
From: Rodger Fox <thylakoid@openmailbox.org>
Date: Wed, 22 Feb 2017 15:08:30 -0800
Subject: [PATCH] gnu: Add lmms. * gnu/packages/music.scm (lmms): New variable.

---
 gnu/packages/music.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 730d981e6..924fb8109 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2016 John J. Foerch <jjfoerch@earthlink.net>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2017 Rodger Fox <thylakoid@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2818,3 +2819,40 @@ collections and wantlists, inventory, and orders.")
 conversions between time and pulses, tempo map handling and more.  The only dependencies
 are a C compiler and glib.  Full API documentation and examples are included.")
     (license license:bsd-2)))
+
+(define-public lmms
+  (package
+    (name "lmms")
+    (version "1.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/LMMS/lmms/archive/v"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+	 "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f              ; No tests to run.
+	         #:validate-runpath? #f))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+     (inputs
+     `(("sdl" ,sdl)
+       ("qt" ,qt-4)
+       ("fltk" ,fltk)
+       ("libogg" ,libogg)
+       ("libsamplerate" ,libsamplerate)
+       ("fluidsynth" ,fluidsynth)
+       ("libvorbis" ,libvorbis)
+       ("alsa-lib" ,alsa-lib)
+       ("portaudio" ,portaudio)
+       ("ladspa" ,ladspa)
+       ("libsndfile1" ,libsndfile)
+       ("libxft" ,libxft)
+       ("freetype2" ,freetype)
+       ("fftw3f" ,fftwf)))
+    (home-page "https://lmms.io/")
+    (synopsis "Music composition tool")
+    (description "LMMS is a digital audio workstation. It includes tools for sequencing melodies and beats and for mixing and arranging songs. It includes instruments based on audio samples and various soft sythesizers. It can receive input from a MIDI keyboard.")
+    (license license:gpl2+)))
-- 
2.11.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-03-21 19:39 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-09  4:47 [PATCH] gnu: Add lmms Rodger Fox
2017-03-15 22:03 ` Leo Famulari
2017-03-17  5:54   ` Rodger Fox
2017-03-21 19:20     ` Leo Famulari
2017-03-21 19:39 ` Leo Famulari
  -- strict thread matches above, loose matches on Subject: below --
2017-02-23 18:13 Rodger Fox
2017-02-24 10:56 ` Julien Lepiller
     [not found] <mailman.54228.1487857637.22740.guix-devel@gnu.org>
2017-02-23 16:38 ` Rodger Fox
2017-02-22 23:18 Rodger Fox
2017-02-23  9:15 ` julien lepiller
2017-02-23 11:30   ` ng0

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).