From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: boost: Enable tests. Date: Wed, 20 Jan 2016 18:01:18 -0600 Message-ID: <59730e8992a19104bf4ab2b35e7a02b2@openmailbox.org> References: <2d4c3c574717ab1fceddcfd58de7bf37@openmailbox.org> <87powvvq0l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM2gw-0007vi-Se for guix-devel@gnu.org; Wed, 20 Jan 2016 19:01:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM2gs-0004sC-Lw for guix-devel@gnu.org; Wed, 20 Jan 2016 19:01:34 -0500 Received: from smtp7.openmailbox.org ([62.4.1.41]:55894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM2gs-0004r0-Fj for guix-devel@gnu.org; Wed, 20 Jan 2016 19:01:30 -0500 In-Reply-To: <87powvvq0l.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ludo@gnu.org Cc: Guix-devel On 2016-01-20 16:34, ludo@gnu.org wrote: > Eric Bavier skribis: >=20 >> This patch turns boost package tests on. 22 of 120 test suites are >> skipped due to know test failures, many of which still fail with the >> upstream development version >> (http://www.boost.org/development/tests/master/developer/summary.html)= . [...] >> It would be nice to get this patch tested on MIPS or ARM, in case >> there are other failing test suites that should be documented and >> skipped on those systems. >=20 > Yeah. >=20 > I think we=E2=80=99ll have to create a branch anyway, so when we do, we= can=20 > wait > and see what Hydra reports. Andreas was kind enough to test the patch on ARM, and it seems there's=20 at least one additional test-suite to skip on that architecture. A branch would be nice. >> From 76322bff6b4de1c0fe810506f451de733c60683a Mon Sep 17 00:00:00 2001 >> From: Eric Bavier >> Date: Fri, 15 Jan 2016 14:46:26 -0600 >> Subject: [PATCH] gnu: boost: Enable tests. >>=20 >> * gnu/packages/boost.scm (boost)[arguments]: Replace 'check' phase. >=20 > [...] >=20 >> + ;; The provided method for running all tests (executing=20 >> b2 in the >> + ;; "status" directory) requires a large amount of disk=20 >> space >> + ;; (>20G) because it does not clean up build artifacts=20 >> after >> + ;; successfully running a test suite. So instead we run=20 >> each test >> + ;; individually, which only requires ~7.7G. >=20 > This is still a lot of disk space. Can you make sure that everything=20 > is > built with -g0? It makes a significant difference for C++ code. I did > that notably for GCC and Inkscape. I'll give that a try and see if it changes things. Thanks for the=20 pointer. >=20 >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((b2 (string-append (getcwd) "/b2")) >> + (test-dirs >> + ;; The instructions at >> + ;;=20 >> http://www.boost.org/development/running_regression_tests.html >> + ;; to run b2 in each libs//test is not=20 >> entirely >> + ;; accurate. Some tests are in subdirectories=20 >> and others >> + ;; in top-level directories. So instead we read= =20 >> the list >> + ;; of test directories from status/Jamfile.v2 >> + (let ((port (open-input-file=20 >> "status/Jamfile.v2")) >> + (start-rx (make-regexp "^run-tests libs=20 >> :")) >> + (end-rx (make-regexp "^[[:space:]]*;")) >> + (dir-rx (make-regexp=20 >> "^[[:space:]]*([a-z0-9/_]+)"))) >=20 > I think it would be nicer to make it a procedure and move it to a > =E2=80=98define=E2=80=99 at the top of the lambda. Will do. >> + (reverse! dirs))) >=20 > =E2=80=98reverse=E2=80=99 is enough. :-) OK. > Otherwise LGTM. Great > I think we should wait until =E2=80=98core-updates=E2=80=99 is merged, = and then you can > push an updated patch to, say, =E2=80=98wip-boost-tests=E2=80=99 based = on =E2=80=98master=E2=80=99. >=20 > WDYT? That's fine with me. Thanks for the review! --=20 `~Eric