From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: Pytest update to 2.9.2 Date: Tue, 6 Dec 2016 11:41:24 +0100 Message-ID: <584695D4.504@crazy-compilers.com> References: <20161205213343.GA20927@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEDBk-00032G-Tt for guix-devel@gnu.org; Tue, 06 Dec 2016 05:41:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEDBh-0003Ci-Nr for guix-devel@gnu.org; Tue, 06 Dec 2016 05:41:32 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:53531) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cEDBh-0003CS-Ho for guix-devel@gnu.org; Tue, 06 Dec 2016 05:41:29 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3tXypt3XKnz3hjdQ for ; Tue, 6 Dec 2016 11:41:26 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3tXypt2hX2zvl2m for ; Tue, 6 Dec 2016 11:41:26 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id kWt8jeEDyccE for ; Tue, 6 Dec 2016 11:41:25 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-159-169.dynamic.mnet-online.de [188.174.159.169]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Tue, 6 Dec 2016 11:41:25 +0100 (CET) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id CBC2B60631 for ; Tue, 6 Dec 2016 11:41:24 +0100 (CET) In-Reply-To: <20161205213343.GA20927@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel Am 05.12.2016 um 22:33 schrieb Leo Famulari: > + (substitute* "testing/test_argcomplete.py" > + (("def test_remove_dir_prefix" line) > + (string-append "@pytest.mark.skip" > + "(reason=3D\"Assumes that /usr exists.\= ")\n " > + line))) These trailing spaces in the replacement string are a bit irritating. Perhaps its better to search for "^\s+def =E2=80=A6" and replace with " = =20 @pytest.skip=E2=80=A6" (leading spaces here). I don't know. Otherwise LGTM. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |