From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodger Fox Subject: Re: [PATCH] gnu: Add lmms Date: Thu, 23 Feb 2017 10:13:54 -0800 Message-ID: <583a6a7b3ffe64633b3009129c6dcba7@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_958663f469857e59b1e44d829a7095c6" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgxw2-0007Et-RO for guix-devel@gnu.org; Thu, 23 Feb 2017 13:16:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgxvz-0002Ca-00 for guix-devel@gnu.org; Thu, 23 Feb 2017 13:16:10 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:33086 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cgxvy-0002Bw-OR for guix-devel@gnu.org; Thu, 23 Feb 2017 13:16:06 -0500 Received: from www.openmailbox.org (unknown [10.0.0.3]) by mail.openmailbox.org (Postfix) with ESMTP id B7B3A5106E2 for ; Thu, 23 Feb 2017 19:13:54 +0100 (CET) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=_958663f469857e59b1e44d829a7095c6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed > It's a good idea to run "./pre-inst-env guix lint PACKAGENAME" which > will pick up long lines for example. > I have a ruler/colored line at character 83 in vim, but I'm not yet > ready with the setup to write correct code again in vim. There's > a similar thing for emacs. > > I would replace the third or second "It" with @code{LMMS} or simply > LMMS. Thanks for pointing that out. I missed that pre-inst-env tool in the manual until you just mentioned it here. That helps a lot. My corrected patch is attached. It passes the linter this time. -Rodger Fox --=_958663f469857e59b1e44d829a7095c6 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-lmms.patch Content-Disposition: attachment; filename=0001-gnu-Add-lmms.patch; size=2636 RnJvbSBhNDBkNDAzMjQzMWQ1YTIyODA5YzI1ZDgxZWNkYzhlZDM3MGU5ODljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2RnZXIgRm94IDx0aHlsYWtvaWRAb3Blbm1haWxib3gub3Jn PgpEYXRlOiBXZWQsIDIyIEZlYiAyMDE3IDE1OjA4OjMwIC0wODAwClN1YmplY3Q6IFtQQVRDSF0g Z251OiBBZGQgbG1tcy4KCiogZ251L3BhY2thZ2VzL211c2ljLnNjbSAobG1tcyk6IE5ldyB2YXJp YWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIHwgNDMgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDQzIGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbXVzaWMuc2NtIGIvZ251L3BhY2thZ2VzL211 c2ljLnNjbQppbmRleCA3MzBkOTgxZTYuLmZlMjRjOTRmNiAxMDA2NDQKLS0tIGEvZ251L3BhY2th Z2VzL211c2ljLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCkBAIC05LDYgKzksNyBA QAogOzs7IENvcHlyaWdodCDCqSAyMDE2IEpvaG4gSi4gRm9lcmNoIDxqamZvZXJjaEBlYXJ0aGxp bmsubmV0PgogOzs7IENvcHlyaWdodCDCqSAyMDE2IEFsZXggR3JpZmZpbiA8YUBhamdyZi5jb20+ CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTcgbmcwIDxjb250YWN0Lm5nMEBjcnlwdG9sYWIubmV0Pgor Ozs7IENvcHlyaWdodCDCqSAyMDE3IFJvZGdlciBGb3ggPHRoeWxha29pZEBvcGVubWFpbGJveC5v cmc+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMjgx OCwzICsyODE5LDQ1IEBAIGNvbGxlY3Rpb25zIGFuZCB3YW50bGlzdHMsIGludmVudG9yeSwgYW5k IG9yZGVycy4iKQogY29udmVyc2lvbnMgYmV0d2VlbiB0aW1lIGFuZCBwdWxzZXMsIHRlbXBvIG1h cCBoYW5kbGluZyBhbmQgbW9yZS4gIFRoZSBvbmx5IGRlcGVuZGVuY2llcwogYXJlIGEgQyBjb21w aWxlciBhbmQgZ2xpYi4gIEZ1bGwgQVBJIGRvY3VtZW50YXRpb24gYW5kIGV4YW1wbGVzIGFyZSBp bmNsdWRlZC4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6YnNkLTIpKSkKKworKGRlZmluZS1wdWJs aWMgbG1tcworICAocGFja2FnZQorICAgIChuYW1lICJsbW1zIikKKyAgICAodmVyc2lvbiAiMS4x LjMiKQorICAgIChzb3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgdXJsLWZldGNo KQorICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHBzOi8vZ2l0aHViLmNvbS9MTU1TL2xt bXMvYXJjaGl2ZS92IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5n eiIpKQorICAgICAgIChmaWxlLW5hbWUgKHN0cmluZy1hcHBlbmQgbmFtZSAiLSIgdmVyc2lvbiAi LnRhci5neiIpKQorICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAgICAgICAgIjFn NzZ6N2hhM2hkNTN2YnFhcTluMXFnNnMzbHc4enphdzUxaW55NnkyYnowajF4cXdjc3IiKSkpKQor ICAgIChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAg ICAgYCgjOnRlc3RzPyAjZiAgICAgICAgICAgICAgOyBObyB0ZXN0cyB0byBydW4uCisgICAgICAg Izp2YWxpZGF0ZS1ydW5wYXRoPyAjZikpIDsgQmluYXJpZXMgaW4gc3ViZGlyZWN0b3JpZXMgb2Yg L2xpYiBhcmUgZGVwZW5kZW50LgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7IEl0 IGZhaWxzIHRoZSBydW5wYXRoIHZhbGlkYXRpb24sIGJ1dCBzdGlsbCB3b3Jrcy4KKyAgICAobmF0 aXZlLWlucHV0cworICAgICBgKCgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpKSkKKyAgICAoaW5w dXRzCisgICAgIGAoKCJzZGwiICxzZGwpCisgICAgICAgKCJxdCIgLHF0LTQpCisgICAgICAgKCJm bHRrIiAsZmx0aykKKyAgICAgICAoImxpYm9nZyIgLGxpYm9nZykKKyAgICAgICAoImxpYnNhbXBs ZXJhdGUiICxsaWJzYW1wbGVyYXRlKQorICAgICAgICgiZmx1aWRzeW50aCIgLGZsdWlkc3ludGgp CisgICAgICAgKCJsaWJ2b3JiaXMiICxsaWJ2b3JiaXMpCisgICAgICAgKCJhbHNhLWxpYiIgLGFs c2EtbGliKQorICAgICAgICgicG9ydGF1ZGlvIiAscG9ydGF1ZGlvKQorICAgICAgICgibGFkc3Bh IiAsbGFkc3BhKQorICAgICAgICgibGlic25kZmlsZTEiICxsaWJzbmRmaWxlKQorICAgICAgICgi bGlieGZ0IiAsbGlieGZ0KQorICAgICAgICgiZnJlZXR5cGUyIiAsZnJlZXR5cGUpCisgICAgICAg KCJmZnR3M2YiICxmZnR3ZikpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vbG1tcy5pby8iKQor ICAgIChzeW5vcHNpcyAiTXVzaWMgY29tcG9zaXRpb24gdG9vbCIpCisgICAgKGRlc2NyaXB0aW9u ICJMTU1TIGlzIGEgZGlnaXRhbCBhdWRpbyB3b3Jrc3RhdGlvbi4gIEl0IGluY2x1ZGVzIHRvb2xz IGZvciBzZXF1ZW5jaW5nCittZWxvZGllcyBhbmQgYmVhdHMgYW5kIGZvciBtaXhpbmcgYW5kIGFy cmFuZ2luZyBzb25ncy4gIExNTVMgaW5jbHVkZXMgaW5zdHJ1bWVudHMgYmFzZWQgb24KK2F1ZGlv IHNhbXBsZXMgYW5kIHZhcmlvdXMgc29mdCBzeXRoZXNpemVycy4gIEl0IGNhbiByZWNlaXZlIGlu cHV0IGZyb20gYSBNSURJIGtleWJvYXJkLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwyKykp KQotLSAKMi4xMS4xCgo= --=_958663f469857e59b1e44d829a7095c6--