From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2. Date: Thu, 10 Nov 2016 11:58:12 +0100 Message-ID: <582452C4.9000700@crazy-compilers.com> References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com> <1478731153-27023-1-git-send-email-h.goebel@crazy-compilers.com> <87vavvtxxb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4n3m-0001PK-Od for guix-devel@gnu.org; Thu, 10 Nov 2016 05:58:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4n3j-00052Y-Nh for guix-devel@gnu.org; Thu, 10 Nov 2016 05:58:22 -0500 In-Reply-To: <87vavvtxxb.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel@gnu.org Am 10.11.2016 um 11:46 schrieb Ludovic Courtès: >> > + (arguments >> > + `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes) > So probably we should only build the Python 2 variant? WDYT? > The main feature of PyPDF2 is that is supports Python 3, what the old pyPdf does not. So we need Python 3. The test suite does not fail in the sense that it shows bugs, but in a way that shows the test suite was not adopted to work with Python 3. The test-suite is negligible anyway. I'll update the comment. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |