From: "Ian Eure" <ian@retrospec.tv>
To: "Lars-Dominik Braun" <lars@6xq.net>
Cc: jgart <jgart@dismail.de>, "Ludovic Courtès" <ludo@gnu.org>,
"Sharlatan Hellseher" <sharlatanus@gmail.com>,
74715@debbugs.gnu.org, me@bonfacemunyoki.com, marius@gnu.org,
guix-devel@gnu.org, tanguy@bioneland.org
Subject: Re: bug#74715: Request for merging "python-team" branch
Date: Sun, 15 Dec 2024 17:53:07 +0000 [thread overview]
Message-ID: <57df3ada-d4a8-472a-8ac0-fd3c30932c8f@app.fastmail.com> (raw)
In-Reply-To: <Z153IS4JWlm0Y_gi@noor.fritz.box>
Hi Lars-Dominik,
On Sun, Dec 15, 2024, at 6:28 AM, Lars-Dominik Braun wrote:
> Hi Ian,
>
>> Since this merge landed, the builds for several Python packages in my personal channel broke. Any package using pyproject-build-system for a Python project using setuptools seems to be affected.
>
> as Sharlatan Hellseher wrote in https://issues.guix.gnu.org/issue/74715#4,
> you need to add python-setuptools and python-wheel to your
> setuptools-based packages. The default python toolchain used by
> pyproject-build-system (python-sans-pip-wrapper from
> gnu/packages/python.scm) does not include these packages any more,
> since they are technically not required and declaring them as *real*
> inputs allows using different versions of these packages more easily
> for packages, which require them. Plus there are quite a few packages,
> which build using different build systems nowadays.
>
Thanks, this worked for me. I skimmed the related bug, but missed this comment. I think the docs for pyproject-build-system are likely the best place for this, as they already mention some of the setuptools/pyproject interaction. I sent a patch (#74899) with some draft language, let me know what you think.
> The python importer should probably be updated to read pyproject.toml
> and parse the [build-system] table (there is a toml parser in Guix now,
> so this should be easy).
>
Would it be helpful to open a bug about this?
Thanks,
-- Ian
next prev parent reply other threads:[~2024-12-15 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bjxo8phy.fsf@gmail.com>
2024-12-10 19:31 ` Request for merging "python-team" branch Sharlatan Hellseher
2024-12-13 15:55 ` bug#74715: " Ludovic Courtès
2024-12-13 17:00 ` jgart
2024-12-15 1:00 ` Ian Eure
2024-12-15 6:24 ` Kaelyn via Development of GNU Guix and the GNU System distribution.
2024-12-15 6:28 ` Lars-Dominik Braun
2024-12-15 10:29 ` Sharlatan Hellseher
2024-12-15 18:12 ` Leo Famulari
2024-12-15 17:53 ` Ian Eure [this message]
2024-12-15 18:05 ` Cayetano Santos
2024-12-15 21:01 ` Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57df3ada-d4a8-472a-8ac0-fd3c30932c8f@app.fastmail.com \
--to=ian@retrospec.tv \
--cc=74715@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=jgart@dismail.de \
--cc=lars@6xq.net \
--cc=ludo@gnu.org \
--cc=marius@gnu.org \
--cc=me@bonfacemunyoki.com \
--cc=sharlatanus@gmail.com \
--cc=tanguy@bioneland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).