From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 4/5] gnu: Add python-imagesize. Date: Fri, 7 Oct 2016 13:07:15 +0200 Message-ID: <57F781E3.1060908@crazy-compilers.com> References: <20161007103250.24046-1-dannym@scratchpost.org> <20161007103250.24046-5-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsSzs-0006jC-0p for guix-devel@gnu.org; Fri, 07 Oct 2016 07:07:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsSzm-00026C-R8 for guix-devel@gnu.org; Fri, 07 Oct 2016 07:07:22 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:38496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsSzm-00024u-KI for guix-devel@gnu.org; Fri, 07 Oct 2016 07:07:18 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3sr6DP0WT6z3hjJ1 for ; Fri, 7 Oct 2016 13:07:16 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3sr6DN6WcfzvlXP for ; Fri, 7 Oct 2016 13:07:16 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id OQe740m8_2p0 for ; Fri, 7 Oct 2016 13:07:16 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-146-233.dynamic.mnet-online.de [188.174.146.233]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Fri, 7 Oct 2016 13:07:15 +0200 (CEST) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5074C601C1 for ; Fri, 7 Oct 2016 13:07:15 +0200 (CEST) In-Reply-To: <20161007103250.24046-5-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Am 07.10.2016 um 12:32 schrieb Danny Milosavljevic: > + (synopsis > + "Gets image size from png/jpeg/jpeg2000/gif files in Python") This is hard to read (and repeated in the description). Please use just "image files of various formats". > + "This package allows determination of image size from > +png/jpeg/jpeg2000/gif files in Python.") Use comma and space instead of /. Please state that this is a pure Python package. I was wondering why there are no inputs, but this really implements the lookup in pure Python. Maybe simply write "in pure Python" -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |