From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 00/14] Change python-build-system (fixes bug 20765) Date: Sun, 2 Oct 2016 19:31:01 +0200 Message-ID: <57F14455.8060506@crazy-compilers.com> References: <1475071107-10765-1-git-send-email-h.goebel@crazy-compilers.com> <57EBCD98.9020407@goebel-consult.de> <87mvism34v.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <57EC008A.4030006@crazy-compilers.com> <87bmz5ih9u.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87wphqesmc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqkbW-0002Uu-TH for guix-devel@gnu.org; Sun, 02 Oct 2016 13:31:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqkbQ-0003Gw-Vi for guix-devel@gnu.org; Sun, 02 Oct 2016 13:31:09 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqkbQ-0003Ew-QA for guix-devel@gnu.org; Sun, 02 Oct 2016 13:31:04 -0400 In-Reply-To: <87wphqesmc.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Am 02.10.2016 um 16:24 schrieb Ludovic Courtès: > >> Subject: [PATCH 2/2] guix: python-build-system: Import setuptools before >> calling `setup.py'. >> >> This is needed for packages using "distutils" instead of "setuptools" >> since the former does not understand the >> "--single-version-externally-managed" flag. Also export __file__ since >> it will be unset when setup.py is called from python "exec". > Please move this explanation as a comment right above the newly-added > code. @marius: I already added this comment, see the fixups on my branch at gitlab (which I'm going to clean up when we all agree on the result). -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |