From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH] gnu: Add python-gunicorn and python2-gunicorn. Date: Tue, 13 Sep 2016 21:22:03 +0200 Message-ID: <57D851DB.2000306@crazy-compilers.com> References: <1473627035-12350-1-git-send-email-h.goebel@crazy-compilers.com> <20160913155133.GC13516@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjtHW-0006Ad-8F for guix-devel@gnu.org; Tue, 13 Sep 2016 15:22:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjtHT-00069L-13 for guix-devel@gnu.org; Tue, 13 Sep 2016 15:22:10 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:51772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjtHS-00068r-QR for guix-devel@gnu.org; Tue, 13 Sep 2016 15:22:06 -0400 In-Reply-To: <20160913155133.GC13516@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Am 13.09.2016 um 17:51 schrieb Leo Famulari: > Thanks for this! Regarding the naming question, I think it's fine to > call it 'gunicorn'. Prefixing with 'python-' is more appropriate for > libraries and other "helper" packages, whereas user facing or > standalone applications can use the plain upstream name, in my opinion. Fine. I'll update (which may take until Thursday) the patch. >> + ;("python-pytest-cov" ,python-pytest-cov) ; optional > I think we should either use pytest-cov or remove this commented line. > What do you think? I added this line for documentation reasons. But I agree, it's better to remove this line and add a real comment. >> +(define-public python2-gunicorn >> + (let ((base (package-with-python2 >> + (strip-python2-variant python-gunicorn)))) >> + ; Note: byte-compiling gunicorn/workers/_gaiohttp.py with Python 2 >> + ; fails, but this module will be available for Python 3 only >> + ; anyway. > Can you elaborate on this? Does python2-gunicorn still work? If so, > okay. Yes. I'll update this comment to make it more clear, too. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |