Re: [PATCH] gnu: Add python-gunicorn and python2-gunicorn.

[Hartmut Goebel <h.goebel@crazy-compilers.com>]

Am 13.09.2016 um 17:51 schrieb Leo Famulari:
> Thanks for this! Regarding the naming question, I think it's fine to
> call it 'gunicorn'. Prefixing with 'python-' is more appropriate for
> libraries and other "helper" packages, whereas user facing or
> standalone applications can use the plain upstream name, in my opinion.

Fine. I'll update (which may take until Thursday) the patch.

>> +       ;("python-pytest-cov" ,python-pytest-cov) ; optional
> I think we should either use pytest-cov or remove this commented line.
> What do you think?

I added this line for documentation reasons. But I agree, it's better to
remove this line and add a real comment.

>> +(define-public python2-gunicorn
>> +  (let ((base (package-with-python2
>> +               (strip-python2-variant python-gunicorn))))
>> +    ; Note: byte-compiling gunicorn/workers/_gaiohttp.py with Python 2
>> +    ; fails, but this module will be available for Python 3 only
>> +    ; anyway.
> Can you elaborate on this? Does python2-gunicorn still work? If so,
> okay.

Yes. I'll update this comment to make it more clear, too.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |