From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 1/2] gnu: add python-django. Date: Mon, 12 Sep 2016 15:58:43 +0200 Message-ID: <57D6B493.9010109@crazy-compilers.com> References: <1471865497-7324-1-git-send-email-h.goebel@crazy-compilers.com> <1471865497-7324-2-git-send-email-h.goebel@crazy-compilers.com> <87sht5tfcf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------010904090309030301020703" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjRl5-0006IK-KD for guix-devel@gnu.org; Mon, 12 Sep 2016 09:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjRl1-00061B-GS for guix-devel@gnu.org; Mon, 12 Sep 2016 09:58:50 -0400 In-Reply-To: <87sht5tfcf.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel@gnu.org This is a multi-part message in MIME format. --------------010904090309030301020703 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, > I finally reviewed this patch and pushed it as > d18197af7844151e38322605b11e0c75b18b55bf with small changes: adjust the= > list of =E2=80=98native-inputs=E2=80=99, use =E2=80=98propagated-inputs= =E2=80=99 for all the run-time > dependencies, use two semicolons for line comments (as opposed to margi= n > comments), and add the patch to gnu/local.mk. Thanks :-) Unfortunately most of the inputs are now mixed now - but maybe I'm wrong here, since I still did not get when to use propagated-inputs and normal inputs for Python packages. [*] 1. setuptools is a run-time dependence, so it needs to be a propagated-input (I assume). This is why there is a comment "Django uses 'pkg_resources' (part of setuptools) to locate templates at run-time. 2. All packages below the line "Taken from tests/requirements/py3.txt." are required for tests only. So I assume they are normal inputs. 3. Same for python2-django: enum34 and mock are used for testing only. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------010904090309030301020703 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi Ludo,

I finally reviewed this patch and pushed it as
d18197af7844151e38322605b11e0c75b18b55bf with small changes: adjust the
list of =E2=80=98native-inputs=E2=80=99, use =E2=80=98propagated-inputs=E2=
=80=99 for all the run-time
dependencies, use two semicolons for line comments (as opposed to margin
comments), and add the patch to gnu/local.mk.

Thanks :-)

Unfortunately most of the inputs are now mixed now - but maybe I'm wrong here, since I still did not get when to use propagated-inputs and normal inputs for Python packages. [*]

  1. setuptools is a run-time dependence, so it needs to be a propagated-input (I assume). This is why there is a comment "Django uses 'pkg_resources' (part of setuptools) to locate templates at run-time.

  2. All packages below the line "Taken from tests/requirements/py3.txt." are required for tests only. So I assume they are normal inputs.

  3. Same for python2-django: enum34 and mock are used for testing only.
--=20
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com   =
            |
| www.crazy-compilers.com | compilers which you thought are impo=
ssible |
--------------010904090309030301020703--