From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] Add python-pythondialog
Date: Wed, 27 Jul 2016 22:17:38 +1000
Message-ID: <5798A662.7020006@uq.edu.au>
References: <87lh1hcp18.fsf@we.make.ritual.n0.is>
	<20160704180530.GB13592@jasmine> <871t39jlzw.fsf@we.make.ritual.n0.is>
	<871t2fgvlk.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bSNmY-0003Em-Hr
	for guix-devel@gnu.org; Wed, 27 Jul 2016 08:17:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bSNmU-0003U7-IP
	for guix-devel@gnu.org; Wed, 27 Jul 2016 08:17:50 -0400
Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:55198
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bSNmT-0003TH-VL
	for guix-devel@gnu.org; Wed, 27 Jul 2016 08:17:46 -0400
In-Reply-To: <871t2fgvlk.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org

Hi there,

On 27/07/16 21:37, ng0 wrote:
> Hi,
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Leo Famulari writes:
>>
>>> On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
>>>> * gnu/packages/python.scm (python-pythondialog): New variable.
>>> For those reading along, python2-pythondialog and python-pythondialog
>>> are separate implementations with different source tarballs.  They are
>>> maintained by the same group.
>>>
>>> But, the package definitions are basically the same. The only
>>> differences are the name, the source and Python version.
>>>
>>> Should one of them inherit from the other, or should we maintain two
>>> independent package definitions?
>> If we inherit, we should let python2- inherit from python3.
>>
>> I was not sure about the right way to process with this, so it
>> ended up in 2 packages.
> There has been no update on this for 3 weeks.
> Could someone look into this and reply?

IMHO python2-pythondialog should inherit from python-dialog as you suggest.

Apologies for the slow review. Would you mind preparing another patch 
please?
Thanks,
ben