unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH] Add python-pythondialog
Date: Wed, 27 Jul 2016 22:17:38 +1000	[thread overview]
Message-ID: <5798A662.7020006@uq.edu.au> (raw)
In-Reply-To: <871t2fgvlk.fsf@we.make.ritual.n0.is>

Hi there,

On 27/07/16 21:37, ng0 wrote:
> Hi,
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Leo Famulari writes:
>>
>>> On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
>>>> * gnu/packages/python.scm (python-pythondialog): New variable.
>>> For those reading along, python2-pythondialog and python-pythondialog
>>> are separate implementations with different source tarballs.  They are
>>> maintained by the same group.
>>>
>>> But, the package definitions are basically the same. The only
>>> differences are the name, the source and Python version.
>>>
>>> Should one of them inherit from the other, or should we maintain two
>>> independent package definitions?
>> If we inherit, we should let python2- inherit from python3.
>>
>> I was not sure about the right way to process with this, so it
>> ended up in 2 packages.
> There has been no update on this for 3 weeks.
> Could someone look into this and reply?

IMHO python2-pythondialog should inherit from python-dialog as you suggest.

Apologies for the slow review. Would you mind preparing another patch 
please?
Thanks,
ben

  reply	other threads:[~2016-07-27 12:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 17:05 [PATCH] Add python-pythondialog ng0
2016-07-04 18:05 ` Leo Famulari
2016-07-04 18:28   ` ng0
2016-07-27 11:37     ` ng0
2016-07-27 12:17       ` Ben Woodcroft [this message]
2016-07-27 12:30       ` Vincent Legoll
2016-07-28  9:34         ` ng0
2016-07-28 10:52           ` Vincent Legoll
2016-07-28 10:53             ` Vincent Legoll
2016-08-02 20:21               ` Leo Famulari
2016-08-04  8:16                 ` ng0
2016-08-07  2:56                   ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5798A662.7020006@uq.edu.au \
    --to=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    --cc=ng0@we.make.ritual.n0.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).