unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add multiqc.
Date: Wed, 29 Jun 2016 09:05:02 +1000	[thread overview]
Message-ID: <5773029E.1000400@uq.edu.au> (raw)
In-Reply-To: <idj7fd9wee7.fsf@bimsb-sys02.mdc-berlin.net>



On 29/06/16 00:56, Ricardo Wurmus wrote:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> * gnu/packages/bioinformatics.scm (multiqc): New variable.
>> ---
>>   gnu/packages/bioinformatics.scm | 30 ++++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 04ed769..45595d0 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -5321,3 +5321,33 @@ group or two ChIP groups run under different conditions.")
>>         (description "This program compares version strings.  It intends to be a
>>   replacement for strverscmp.")
>>         (license license:gpl3+))))
>> +
>> +(define-public multiqc
>> +  (package
>> +    (name "multiqc")
>> +    (version "0.6")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://pypi.python.org/packages/23/d9/95a5e62eea95f220007d7a6683d0da1ee1d9f99e6932bcff793b6601ef15/multiqc-"
>> +             version ".tar.gz"))

I think 'pypi-uri' would be better here, now that it handles these kinds 
of URLs. We should change 'import' so that these long URLs are not printed.

Thanks for the patch.
ben

  reply	other threads:[~2016-06-28 23:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 14:50 [PATCH] gnu: Add multiqc Ricardo Wurmus
2016-06-28 14:56 ` Ricardo Wurmus
2016-06-28 23:05   ` Ben Woodcroft [this message]
2016-07-05 14:04     ` Ricardo Wurmus
2016-06-28 15:30 ` Thompson, David
2016-06-28 22:02 ` Ludovic Courtès
2016-07-05 14:07   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5773029E.1000400@uq.edu.au \
    --to=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).