From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH 3/3] gnu: Add r-vegan. Date: Tue, 21 Jun 2016 21:43:49 +1000 Message-ID: <57692875.5020702@gmail.com> References: <1466081273-15127-1-git-send-email-donttrustben@gmail.com> <1466081273-15127-4-git-send-email-donttrustben@gmail.com> <20160618005616.GA25816@jasmine> <878ty11e91.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFK65-0007GG-Qz for guix-devel@gnu.org; Tue, 21 Jun 2016 07:44:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFK61-0007mk-RT for guix-devel@gnu.org; Tue, 21 Jun 2016 07:44:01 -0400 In-Reply-To: <878ty11e91.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Leo Famulari Cc: guix-devel@gnu.org On 19/06/16 23:48, Ludovic Courtès wrote: > Leo Famulari skribis: > >> On Thu, Jun 16, 2016 at 10:47:53PM +1000, Ben Woodcroft wrote: >>> * gnu/packages/bioinformatics.scm (r-vegan): New variable. >>> * gnu/packages/patches/vegan-revert-test-deletion.patch: New file. >> This patch is 460K uncompressed. gzip reduces it to 124K. Currently >> `guix pull` downloads a 10.2 MiB tarball. Just food for thought ;) > Heh. AIUI, the patch simply removes files; it’s more space-efficient > and clearer to do it in a ‘snippet’. The idea is actually to revert the deletion (of the test files). Instead of including the 'revert' patch taking up space, I sourced the patch from GitHub as a native-input and applied it in reverse, and pushed this series. Thanks for picking this up. ben