From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH 1/3] gnu: Add python-screed. Date: Sat, 18 Jun 2016 08:57:38 +1000 Message-ID: <57648062.7080907@uq.edu.au> References: <1466126601-30932-1-git-send-email-donttrustben@gmail.com> <1466126601-30932-2-git-send-email-donttrustben@gmail.com> <20160617020737.GB25910@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE2i7-0005Ls-C8 for Guix-devel@gnu.org; Fri, 17 Jun 2016 18:58:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE2i3-0004D5-Ek for Guix-devel@gnu.org; Fri, 17 Jun 2016 18:57:58 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:35167 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE2i2-0004By-QW for Guix-devel@gnu.org; Fri, 17 Jun 2016 18:57:55 -0400 In-Reply-To: <20160617020737.GB25910@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , Ben Woodcroft Cc: Guix-devel@gnu.org On 17/06/16 12:07, Leo Famulari wrote: > On Fri, Jun 17, 2016 at 11:23:19AM +1000, Ben Woodcroft wrote: >> * gnu/packages/bioinformatics.scm (python-screed, python2-screed): >> New variables. >> + (uri (string-append >> + "https://pypi.python.org/packages/a0/6b/" >> + "a90c7ab7b0ad1eab211053c85c1242a81379f34c5f5933392079c9b36858" > Can you keep the hash on a single line? Just to reduce noise in the > commit log for future updates... OK. > >> + (synopsis "Short read sequence utils") > s/utils/utilities "database utilities" would be even better I think. > >> + (description "Screed parses FASTA and FASTQ files and generates databases. > Can you unpack these acronyms? Acronyms are no fun in descriptions I agree. But the problem here is that FASTA and FASTQ aren't really acronyms, and besides these terms are extremely well known (like 'tar' or 'zip'). On a side note, FASTA was first used by the "FASTA" program circa 1985 (just like I am). And just like me it is still going - last release was April. I might have a go at packaging it. ben