From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <donttrustben@gmail.com>
Subject: Re: [PATCH 2/2] gnu: Add ruby-puma.
Date: Fri, 10 Jun 2016 19:37:13 +1000
Message-ID: <575A8A49.8070206@gmail.com>
References: <1465390550-4974-1-git-send-email-donttrustben@gmail.com>
	<1465390550-4974-3-git-send-email-donttrustben@gmail.com>
	<CAJ=RwfaZoSZwHNtMyzCbT6Shqj6nLMhyvJu0OciAvn6tVvQKkg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60773)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1bBIsX-0005jz-6A
	for guix-devel@gnu.org; Fri, 10 Jun 2016 05:37:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1bBIsS-0001Mx-V8
	for guix-devel@gnu.org; Fri, 10 Jun 2016 05:37:24 -0400
Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]:36545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1bBIsS-0001Mr-OL
	for guix-devel@gnu.org; Fri, 10 Jun 2016 05:37:20 -0400
Received: by mail-pf0-x22c.google.com with SMTP id t190so22127723pfb.3
	for <guix-devel@gnu.org>; Fri, 10 Jun 2016 02:37:20 -0700 (PDT)
In-Reply-To: <CAJ=RwfaZoSZwHNtMyzCbT6Shqj6nLMhyvJu0OciAvn6tVvQKkg@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>

Thanks Dave.

On 08/06/16 23:13, Thompson, David wrote:
> On Wed, Jun 8, 2016 at 8:55 AM, Ben Woodcroft <donttrustben@gmail.com> wrote:
>> +         (add-before 'build 'fix-gemspec
>> +           (lambda _
>> +             (substitute* "puma.gemspec"
>> +               (("git ls-files") "find * |sort"))
>> +             #t)))))
> Food for thought: With the prevalence of "git ls-files" in gemspecs
> (thanks to Bundler), maybe we should consider adding a phase to
> ruby-build-system that performs this substitution.

Sounds good to me. Next time..

>> +    (native-inputs
>> +     `(("ruby-hoe" ,ruby-hoe)
>> +       ("ruby-rake-compiler" ,ruby-rake-compiler)
>> +       ("ruby-hoe-git" ,ruby-hoe-git)
>> +       ("ruby-rack" ,ruby-rack)))
> Why are these native inputs?  rake-compiler makes sense because it's
> build-time only, but rack is most definitely a runtime dependency that
> should be in propagated-inputs.  What environment have you been using
> to test these packages?

Well, I did send this off a bit too quickly, in part because I still 
cannot get containers working after updating Ubuntu.
https://lists.gnu.org/archive/html/help-guix/2016-05/msg00003.html

You were right about the inputs to hoe-git. However, as it turns out I'm 
not sure rack is needed for puma, actually. For instance this works with 
the current patch:
$ cat >/tmp/config.ru

run Proc.new { |env| ['200', {'Content-Type' => 'text/html'}, ['get rack\'d']] }

$ environment --pure --ad-hoc ruby ruby-puma -- puma /tmp/config.ru

Also, rack is not mentioned in the gemspec. WDYT?

ben