From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH 01/10] gnu: Add emacs-smex. Date: Fri, 3 Jun 2016 22:10:06 +1000 Message-ID: <5751739E.6030909@uq.edu.au> References: <20160601140538.20311-1-dthompson2@worcester.edu> <87vb1slz61.fsf@gmail.com> <87eg8e4rkw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8nvq-0000pe-Na for guix-devel@gnu.org; Fri, 03 Jun 2016 08:10:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8nvp-0002Is-A6 for guix-devel@gnu.org; Fri, 03 Jun 2016 08:10:30 -0400 In-Reply-To: <87eg8e4rkw.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , "Thompson, David" Cc: guix-devel , Alex Kost , David Thompson On 06/03/2016 06:14 PM, Ludovic Court=C3=A8s wrote: > "Thompson, David" skribis: > >> On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost wrote: >>> David Thompson (2016-06-01 17:05 +0300) wrote: >>> >>>> From: David Thompson >>>> >>>> * gnu/packages/emacs.scm (emacs-smex): New variable. >>>> --- >>>> gnu/packages/emacs.scm | 22 ++++++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> >>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >>>> index b7c0a1f..71f2f8b 100644 >>>> --- a/gnu/packages/emacs.scm >>>> +++ b/gnu/packages/emacs.scm >>>> @@ -10,6 +10,7 @@ >>>> ;;; Copyright =C2=A9 2015, 2016 Christopher Allan Webber >>>> ;;; Copyright =C2=A9 2016 humanitiesNerd >>>> ;;; Copyright =C2=A9 2016 Efraim Flashner >>>> +;;; Copyright =C2=A9 2016 David Thompson >>>> ;;; >>>> ;;; This file is part of GNU Guix. >>>> ;;; >>>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.") >>>> Emacs default configuration in uncontroversial ways that nearly ev= eryone can >>>> agree upon.") >>>> (license license:gpl3+))) >>>> + >>>> +(define-public emacs-smex >>>> + (package >>>> + (name "emacs-smex") >>>> + (version "3.0") >>>> + (source (origin >>>> + (method url-fetch) >>>> + (uri (string-append "https://raw.githubusercontent.co= m" >>>> + "/nonsequitur/smex/" version "/sm= ex.el")) >>> Hm, I see in some packages you use these "githubusercontent" URLs >>> instead of a= s >>> we usually do for github. IIUC you did it to avoid extra files >>> (".gitignore", etc.) in the final package directory, right? If so, I >>> think it is not needed, I would still use a link to a tagged source c= ode >>> archive. Moreover I think it's a problem of emacs-build-system that >>> these uninteresting files are not removed. >>> >>> Overall, I don't mind against "githubusercontent", I was just wonderi= ng. >>> Actually, I think you found a good way how to pick the needed files t= o >>> make several packages from a single repo (as you did for >>> "ido-ubiquitous" and "ido-completing-read+"). >> Yes, I did this to avoid all sorts of unnecessary files making into >> the store, as well as making it more closely mimic the single elisp >> files that were released on MELPA or whatever. These URLs are stable, >> so I thought it had a good clever/useful hack ratio. :) > I think the downside is that the GitHub updater won=E2=80=99t be able t= o > identify these, although I=E2=80=99m not 100% sure of that. I haven't actually tested but I would think that is right Ludo. However,=20 I expect this issue is solvable with modifications to the GitHub updater. ben