From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [Patch] ruby-byebug@9.0.5 Date: Thu, 2 Jun 2016 22:19:59 +1000 Message-ID: <5750246F.5080006@uq.edu.au> References: <87shwyxmnv.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> <57500842.5070000@uq.edu.au> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040309040901050704070108" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Rbj-0007fc-Dc for guix-devel@gnu.org; Thu, 02 Jun 2016 08:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8Rbc-0002op-Lq for guix-devel@gnu.org; Thu, 02 Jun 2016 08:20:14 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:57520 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Rbc-0002lD-2e for guix-devel@gnu.org; Thu, 02 Jun 2016 08:20:08 -0400 In-Reply-To: <57500842.5070000@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Matthew Jordan , guix-devel This is a multi-part message in MIME format. --------------040309040901050704070108 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 06/02/2016 08:19 PM, Ben Woodcroft wrote: > > On 06/01/2016 01:38 AM, Matthew Jordan wrote: >> +(define-public ruby-byebug-9 It seems I was off-base a bit here. There was already a ruby-byebug packaged, but it was somewhat out of date. Shall we simply update the existing package instead of creating a new package? I had a go at re-enabling tests which were disabled in the original package - see the attached patch. Unfortunately it is still failing a few tests. Would you like to take a look into why this might be? Thanks, ben --------------040309040901050704070108 Content-Type: text/x-patch; name="0001-gnu-ruby-byebug-Update-to-9.0.5.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-ruby-byebug-Update-to-9.0.5.patch" >From c75cc9bd3af585907ef019d43236f12cc70cf832 Mon Sep 17 00:00:00 2001 From: Ben Woodcroft Date: Thu, 2 Jun 2016 22:06:46 +1000 Subject: [PATCH] gnu: ruby-byebug: Update to 9.0.5. * gnu/packages/ruby.scm (ruby-byebug): Update to 9.0.5. [source]: Use 'GitHub' source. [arguments]: Enable tests. [native-inputs]: Add dependencies for tests. --- gnu/packages/ruby.scm | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 6eebd9a..68e42be 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -2724,17 +2724,48 @@ with PostgreSQL 8.4 and later.") (define-public ruby-byebug (package (name "ruby-byebug") - (version "6.0.2") + (version "9.0.5") (source (origin (method url-fetch) - (uri (rubygems-uri "byebug" version)) + (uri (string-append + "https://github.com/deivid-rodriguez/byebug/archive/v" version + ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "0537h9qbhr6csahmzyn4lk1g5b2lcligbzd21gfy93nx9lbfdnzc")))) + "0apgk5d2s68rzmzli09ryqigbk2nx7k5r01qw0iz51pp7m7hm34l")))) (build-system ruby-build-system) (arguments - '(#:tests? #f)) ; no tests + `(#:phases + (modify-phases %standard-phases + ;; Most of the dependencies are not needed for building and testing, + ;; so remove them. + (add-before 'build 'remove-dependencies + (lambda _ + (substitute* "Gemfile" + (("gem .*") "")) + (substitute* "Rakefile" + (("require 'chandler/tasks'") "")) + #t)) + ;; Tests require an installed gem, so run tests after install phase. + (delete 'check) + (add-after 'install 'check-after-install + (lambda* (#:key outputs #:allow-other-keys) + (setenv "GEM_PATH" + (string-append + (getenv "GEM_PATH") + ":" + (gem-home (assoc-ref outputs "out") + ,(package-version ruby)))) + (and (system* "rake" "compile") + (zero? (system* "rake" "test")))))))) + (native-inputs + `(("bundler" ,bundler) + ("ruby-yard" ,ruby-yard) + ("ruby-rake-compiler" ,ruby-rake-compiler) + ("ruby-simplecov" ,ruby-simplecov) + ("ruby-pry" ,ruby-pry))) (synopsis "Debugger for Ruby 2") (description "Byebug is a Ruby 2 debugger implemented using the Ruby 2 TracePoint C API for execution control and the Debug Inspector C API for call -- 2.7.4 --------------040309040901050704070108--