From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [Patch] ruby-byebug@9.0.5 Date: Thu, 2 Jun 2016 20:19:46 +1000 Message-ID: <57500842.5070000@uq.edu.au> References: <87shwyxmnv.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8PjM-0000XF-2K for guix-devel@gnu.org; Thu, 02 Jun 2016 06:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8PjI-0005VZ-0u for guix-devel@gnu.org; Thu, 02 Jun 2016 06:19:59 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:52948 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8PjH-0005US-Di for guix-devel@gnu.org; Thu, 02 Jun 2016 06:19:55 -0400 In-Reply-To: <87shwyxmnv.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Matthew Jordan , guix-devel Hi Matthew. Thank you for the patch. On 06/01/2016 01:38 AM, Matthew Jordan wrote: > +(define-public ruby-byebug-9 Is there a reason this variable includes "-9"? Since 9.0.5 is the newest version, I don't think it is necessary. > + (package > + (name "ruby-byebug") > + (version "9.0.5") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "byebug" version)) > + (sha256 > + (base32 > + "18sdnscwwm76i2kbcib2ckwfwpq8b1dbfr97gdcx3j1x547yqv9x")))) > + (build-system ruby-build-system) > + (arguments > + `(#:tests? #f)) I imagine you disabled tests because there was no Rakefile in the gem. In that case, we should source byebug from a release on GitHub, so that we can run the tests. I hope there are not too many dependent packages. > + (synopsis "Byebug is a Ruby 2 debugger.") Perhaps simply "A Ruby 2 debugger" omitting the full stop at the end as per 'guix lint'? > + (description > + "Byebug is a Ruby 2 debugger. It's implemented using the Ruby 2 > +TracePoint C API for execution control and the Debug Inspector C API for call > +stack navigation. The core component provides support that front-ends can > +build on. It provides breakpoint handling and bindings for stack frames among > +other things and it comes with an easy to use command line interface.") Other than s/It's/It is/ I think. I'm not sure of the policy on abbreviations, but that feels right to me. > + (home-page > +"http://github.com/deivid-rodriguez/byebug") > + (license license:bsd-3))) Thanks, ben