unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Matthew Jordan <matthewjordandevops@yandex.com>,
	guix-devel <guix-devel@gnu.org>
Subject: Re: [Patch] ruby-spring
Date: Wed, 1 Jun 2016 22:49:36 +1000	[thread overview]
Message-ID: <574ED9E0.7070505@uq.edu.au> (raw)
In-Reply-To: <87twhexms6.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>



On 01/06/16 01:36, Matthew Jordan wrote:
> This is dependent on ruby-debug-inspector patch.
I'm more supportive of this being in a new rails.scm file than 
ruby-debug-inspector. I made some changes to your patch. Here's the 
diff, WDYT?

I think it could still do with an improved synopsis and description at 
least. Would you like to do this and submit a properly formatted patch 
please?

Thanks.

+
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       ;; Fetch from github as the gem does not contain testing code.
+       (uri (string-append
+             "https://github.com/rails/spring/archive/v"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0czc4mkwfngcqmna49a0l98f6wlhdq2i8gwr63lrmk90d9k25x1n"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:test-target "test:unit"
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'remove-bump
+           (lambda _
+             (substitute* "spring.gemspec"
+               (("gem.add_development_dependency 'bump'") ""))
+             (substitute* "Rakefile"
+               (("require \\\"bump/tasks\\\"") ""))
+             #t)))))
+    (native-inputs
+     `(("bundler" ,bundler)
+       ("ruby-activesupport" ,ruby-activesupport)))
+    (synopsis
+     "Preloads your application so things like console, rake and tests 
run faster")
+    (description
+     "Preloads your application so things like console, rake and tests 
run faster")
+    (home-page "https://github.com/rails/spring")
+    (license license:expat)))

  reply	other threads:[~2016-06-01 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 15:36 [Patch] ruby-spring Matthew Jordan
2016-06-01 12:49 ` Ben Woodcroft [this message]
2016-06-01 19:05   ` Matthew Jordan
2016-06-01 23:03     ` Ben Woodcroft
2016-06-03  5:39       ` Matthew Jordan
2016-06-03 23:43         ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574ED9E0.7070505@uq.edu.au \
    --to=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    --cc=matthewjordandevops@yandex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).