From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [Patch] Add python-rope Date: Sat, 21 May 2016 09:53:27 +1000 Message-ID: <573FA377.5030003@uq.edu.au> References: <87y474st15.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------090008030200000508030305" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3uEh-0006H8-T6 for guix-devel@gnu.org; Fri, 20 May 2016 19:53:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3uEd-0004Du-Tm for guix-devel@gnu.org; Fri, 20 May 2016 19:53:43 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:35353 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3uEd-000479-9T for guix-devel@gnu.org; Fri, 20 May 2016 19:53:39 -0400 In-Reply-To: <87y474st15.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Lukas Gradl , guix-devel@gnu.org This is a multi-part message in MIME format. --------------090008030200000508030305 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Lukas, Thank you for the patch. On 21/05/16 00:28, Lukas Gradl wrote: > Hello, > > This patch adds the Rope refactoring library for python. > I am only interested in this package as a dependency of elpy. Looking forward to trying elpy out. > There is no particular reason why the old (0.10.2) would be needed, > AFAIK. OK. Is it necessary then? We try not to keep old packages around if possible. > There are some tests that fail on the python-3 version. According to > this (https://groups.google.com/forum/#!topic/rope-dev/rmimG01CHUk), > upstream seems to have no particular interest in fixing that at the > moment. The rope_py3k doesn't appear to be maintained, the repository at https://bitbucket.org/zjes/rope-0.9.3_py3k/ has been deleted and the last release was in 2013. Do you use this library yourself? Otherwise it is an unmaintained library lacking unit tests. If you are confident of including it I'd say rename it to rope_py3k as it is more than a fork of rope, commit it separately, and enable tests where possible (most pass according to your link). WDYT? Do you know if the rope you have packaged for python2 works on python3 ? I did some digging, the short answer to this question is no, not yet, unfortunately. https://github.com/python-rope/rope/issues/57 I'll only review the python2-rope@0.10.3 for now then. > +(define-public python2-rope > + (package > + (name "python2-rope") > + (version "0.10.3") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "rope" version)) > + (sha256 > + (base32 > + "18k5znhpwvrfck3yp0jmhd5j8r0f0s8bk1zh5yhs2cfgmfhbwigb")))) > + (arguments > + `(#:python ,python-2)) Might be good to add a comment here saying only python2 is supported, with a URL so that later we can check on progress. > + (build-system python-build-system) > + (native-inputs > + `(("python2-unittest2" ,python2-unittest2) > + ("python2-setuptools" ,python2-setuptools))) > + (home-page "http://rope.sf.net/") https://github.com/python-rope/rope might be a better choice since the sf address redirects there. > + (synopsis "Refactoring library for Python") > + (description "Rope is a Refactoring library for Python.") Would it be possible to expand on this description, perhaps with a few examples of refactoring processes? Also s/Refactoring/refactoring/. > + (license gpl2))) > + Thanks. ben --------------090008030200000508030305 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by newmailhub.uq.edu.au id u4KNrT9U002423 Hi Lukas,

Thank you for the patch.

On 21/05/16 00:28, Lukas Gradl wrote:<= br> 
Hello,

This patch adds the Rope refactoring library for python.
I am only interested in this package as a dependency of elpy.

Looking forward to trying elpy out.

There is no particular reason why the old (0.10.2) w=
ould be needed,
AFAIK.

OK. Is it necessary then? We try not to keep old packages around if possible.

There are some tests that fail on the python-3 versi=
on.  According to
this (https://groups.google.com/forum/#!t=
opic/rope-dev/rmimG01CHUk),
upstream seems to have no particular interest in fixing that at the
moment.
The rope_py3k doesn't appear to be maintained, the repository at https://bitbucket.org/zjes/rope-0.9.3_py3k/ has been deleted and the last release was in 2013. Do you use this library yourself? Otherwise it is an unmaintained library lacking unit tests. If you are confident of including it I'd say rename it to rope_py3k as it is more than a fork of rope, commit it separately, and enable tests where possible (most pass according to your link). WDYT?

Do you know if the rope you have packaged for python2 works on python3 ? I did some digging, the short answer to this question is no, not yet, unfortunately.
https://github.com/python-rope/rope/issues/57
I'll only review the python2-rope@0.10.3 for now then.

+(define-public python2-rope +=A0 (package
+=A0=A0=A0 (name "python2-rope")
+=A0=A0=A0 (version "0.10.3")
+=A0=A0=A0 (source
+=A0=A0=A0=A0 (origin
+=A0=A0=A0=A0=A0 (method url-fetch)
+=A0=A0=A0=A0=A0 (uri (pypi-uri "rope" version))<= br> +=A0=A0=A0=A0=A0 (sha256
+=A0=A0=A0=A0=A0=A0=A0 (base32
+=A0=A0=A0=A0=A0=A0=A0=A0 "18k5znhpwvrfck3yp0jmhd5j8r0f0s8bk1zh5yhs2cfgmfhbwigb"))))
+=A0=A0=A0 (arguments
+=A0=A0=A0=A0 `(#:python ,python-2))
Might be good to add a comment here saying only python2 is supported, with a URL so that later we can check on progress.<= br>
+=A0=A0=A0 (build-system python-build-system)
+=A0=A0=A0 (native-inputs
+=A0=A0=A0=A0 `(("python2-unittest2" ,python2-unittest2)
+=A0=A0=A0=A0=A0=A0 ("python2-setuptools" ,python2-setupto= ols)))
+=A0=A0=A0 (home-page "http://rope.sf.net/")
https://github.com/python-rope/rope might be a better = choice since the sf address redirects there.
+=A0=A0=A0 (synopsis "Refactoring library for Python")
+=A0=A0=A0 (description "Rope is a Refactoring library for Python.")
Would it be possible to expand on this description, perhaps with a few examples of refactoring processes? Also s/Refactoring/refactoring/.
+=A0=A0=A0 (license gpl2)))
+

Thanks.
ben
--------------090008030200000508030305--