unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Cyril Roelandt <tipecaml@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/10] gnu: Update python-unittest2 to 0.6.0
Date: Fri, 6 May 2016 03:28:39 +0200	[thread overview]
Message-ID: <572BF347.9080301@gmail.com> (raw)
In-Reply-To: <20160430213306.GB32505@jasmine>

On 04/30/2016 11:33 PM, Leo Famulari wrote:
> As with python-cmd2, could you if setuptools is required for the
> python-3 variant?
> 

So, I applied the following patch:


--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1520,8 +1520,7 @@ matching them against a list of media-ranges.")
     (build-system python-build-system)
     (propagated-inputs
      `(("python-six" ,python-six)))
-    (inputs
-     `(("python-setuptools" ,python-setuptools)))
+    ;(inputs `(("python-setuptools" ,python-setuptools)))
     (home-page "http://pypi.python.org/pypi/unittest2")
     (synopsis "Python unit testing library")
     (description
@@ -1530,7 +1529,12 @@ standard library.")
     (license psfl)))

 (define-public python2-unittest2
-  (package-with-python2 python-unittest2))
+  ;(package-with-python2 python-unittest2))
+  (let ((base (package-with-python2 (strip-python2-variant
python-unittest2))))
+    (package
+      (inherit base)
+      (native-inputs `(("python2-setuptools" ,python2-setuptools)
+                       ,@(package-native-inputs base))))))

 (define-public python-py
   (package


I can still build python-unittest2 and python-barbicanclient:

$ ./pre-inst-env guix build python-unittest2
/gnu/store/kh4nbzvqv9ic535xls92q8j6p6iz30kk-python-unittest2-0.6.0
$ ./pre-inst-env guix build python-barbicanclient
/gnu/store/n3kas9l1ffcf84gdbx1sswzrm4cl93n6-python-barbicanclient-4.0.1

I can still build python2-unittest2:

$ ./pre-inst-env guix build python2-unittest2
/gnu/store/ld9l5y5hxs19d15babphp7mv1kxsak55-python2-unittest2-0.6.0

But I can no longer build python2-barbicanclient:

http://paste.debian.net/682000/

>> > -       #:tests? #f)))) ; no setup.py test command
> Disabling two tests is an improvment over this! Did you find anyone else
> on the net having trouble with these two tests?

Not really, I was quite happy with enabling most of them for Python2 and
did not look any further, since my main goal was packaging
python-barbicanclient.

Cyril.

  reply	other threads:[~2016-05-06  1:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 14:20 [PATCH 00/10] Add python-barbicanclient Cyril Roelandt
2016-04-29 14:20 ` [PATCH 01/10] gnu: python2-jsonschema: make python-functools32 a propagated input Cyril Roelandt
2016-04-29 14:20 ` [PATCH 02/10] gnu: Update python-unittest2 to 0.6.0 Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-05-06  1:28     ` Cyril Roelandt [this message]
2016-05-06 18:49       ` Leo Famulari
2016-05-03 18:19   ` Efraim Flashner
2016-05-06  0:08     ` Cyril Roelandt
2016-04-29 14:20 ` [PATCH 03/10] gnu: Add python-cmd2 Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-04-29 14:20 ` [PATCH 04/10] gnu: remove test-only depencies of python-pbr Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-05-03 18:23     ` Efraim Flashner
2016-05-03 18:27   ` Efraim Flashner
2016-04-29 14:20 ` [PATCH 05/10] gnu: Add python-pyinotify Cyril Roelandt
2016-04-29 14:20 ` [PATCH 06/10] gnu: Update python-oslo.log to 3.5.0 Cyril Roelandt
2016-04-29 14:21 ` [PATCH 07/10] gnu: Add python-funcsigs Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-05-03 18:25   ` Efraim Flashner
2016-05-06  1:33     ` Cyril Roelandt
2016-04-29 14:21 ` [PATCH 08/10] gnu: Update python-mock to 2.0.0 Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-04-29 14:21 ` [PATCH 09/10] gnu: Add python-cliff Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-04-29 14:21 ` [PATCH 10/10] gnu: Add python-barbicanclient Cyril Roelandt
2016-04-30 21:33   ` Leo Famulari
2016-04-30 21:33 ` [PATCH 00/10] " Leo Famulari
2016-05-01 16:41 ` Leo Famulari
2016-05-06  1:34   ` Cyril Roelandt
2016-05-06 18:51     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572BF347.9080301@gmail.com \
    --to=tipecaml@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).