From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH 02/10] gnu: Add python-bz2file. Date: Sun, 24 Apr 2016 23:17:41 +1000 Message-ID: <571CC775.201@gmail.com> References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com> <1461244921-7412-3-git-send-email-donttrustben@gmail.com> <57191AD5.9050908@goebel-consult.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------040201040304040900050002" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJv7-0003bm-7w for guix-devel@gnu.org; Sun, 24 Apr 2016 09:17:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJv2-0001cD-8E for guix-devel@gnu.org; Sun, 24 Apr 2016 09:17:53 -0400 Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]:32954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJv1-0001c9-TO for guix-devel@gnu.org; Sun, 24 Apr 2016 09:17:48 -0400 Received: by mail-pa0-x243.google.com with SMTP id vv3so14890428pab.0 for ; Sun, 24 Apr 2016 06:17:47 -0700 (PDT) In-Reply-To: <57191AD5.9050908@goebel-consult.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel , guix-devel@gnu.org This is a multi-part message in MIME format. --------------040201040304040900050002 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Hartmut, Thanks for your comments. On 22/04/16 04:24, Hartmut Goebel wrote: > Am 21.04.2016 um 15:21 schrieb Ben Woodcroft: >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + ;; python setup.py test does not work as of 0.98 >> + ;; but there is only the one test file >> + (replace 'check >> + (lambda _ (zero? (system* "python" "test_bz2file.py"))))))) > > I wonder if this is actually working. The python-3 package does not > include "python" (except if this was changed the last days). As I understand, python-wrapper, which provides python as a symlink to python3, as a native input. And, it works. >> + (description >> + "Bz2file is a Python library for reading and writing bzip2-compressed >> +files. It contains a drop-in replacement for the file interface in the > > I do not understand "replacement for the file interface". If this like > the "zipfile" module? Better now? (description "Bz2file is a Python library for reading and writing bzip2-compressed files. It contains a drop-in replacement for the I/O interface in the standard library's @code{bz2} module, including features from the latest development version of CPython that are not available in older releases.") ta, ben --------------040201040304040900050002 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Hartmut,

Thanks for your comments.

On 22/04/16 04:24, Hartmut Goebel wrote:
Am 21.04.2016 um 15:21 schrieb Ben Woodcroft:
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; python setup.py test does not work as of 0.98
+         ;; but there is only the one test file
+         (replace 'check
+           (lambda _ (zero? (system* "python" "test_bz2file.py")))))))

I wonder if this is actually working. The python-3 package does not include "python" (except if this was changed the last days).

As I understand, python-wrapper, which provides python as a symlink to python3, as a native input. And, it works.

+    (description
+     "Bz2file is a Python library for reading and writing bzip2-compressed
+files.  It contains a drop-in replacement for the file interface in the

I do not understand "replacement for the file interface". If this like the "zipfile" module?

Better now?

    (description
     "Bz2file is a Python library for reading and writing bzip2-compressed
files.  It contains a drop-in replacement for the I/O interface in the
standard library's @code{bz2} module, including features from the latest
development version of CPython that are not available in older releases.")


ta,
ben
--------------040201040304040900050002--