From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <woodibe@gmail.com>
Subject: Re: [PATCH 08/10] gnu: python-ipython: Use 'python2-variant'.
Date: Sun, 24 Apr 2016 23:11:19 +1000
Message-ID: <571CC5F7.2050703@gmail.com>
References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com>
	<1461244921-7412-9-git-send-email-donttrustben@gmail.com>
	<idjvb3b804k.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34907)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <woodibe@gmail.com>) id 1auJou-0001fx-P4
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 09:11:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <woodibe@gmail.com>) id 1auJor-0000AD-Jl
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 09:11:28 -0400
Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:33220)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <woodibe@gmail.com>) id 1auJor-0000A6-CJ
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 09:11:25 -0400
Received: by mail-pa0-x235.google.com with SMTP id zm5so54537571pac.0
	for <Guix-devel@gnu.org>; Sun, 24 Apr 2016 06:11:25 -0700 (PDT)
In-Reply-To: <idjvb3b804k.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org



On 22/04/16 01:14, Ricardo Wurmus wrote:
> Ben Woodcroft <donttrustben@gmail.com> writes:
>
>> * gnu/packages/python.scm (python-ipython)[properties]: New field.
>> (python2-ipython): Use 'strip-python2-variant'.
> The commit message should mention the changes to the “inputs” and
> “propagated-input” fields because it isn’t obvious whether the list of
> inputs actually stays the same.

I still struggle with commit messages, does this sound OK as it is in v2?

     gnu: python-ipython: Use 'python2-variant'.

     * gnu/packages/python.scm (python-ipython)[properties]: New field.
     (python2-ipython): Use 'strip-python2-variant'.
     [inputs, propagated-inputs]: Do not redefine inherited values.

Thanks,
ben