From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Re: [PATCH 2/5] gnu: Add avr-gcc. Date: Thu, 14 Apr 2016 16:53:59 +0300 Message-ID: <570FA0F7.4060909@gmail.com> References: <1460639824-9976-1-git-send-email-dthompson2@worcester.edu> <1460639824-9976-3-git-send-email-dthompson2@worcester.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqhih-0001jX-10 for guix-devel@gnu.org; Thu, 14 Apr 2016 09:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqhid-0005aH-0a for guix-devel@gnu.org; Thu, 14 Apr 2016 09:54:06 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqhic-0005a0-QH for guix-devel@gnu.org; Thu, 14 Apr 2016 09:54:02 -0400 Received: by mail-wm0-x244.google.com with SMTP id a140so23128182wma.2 for ; Thu, 14 Apr 2016 06:54:02 -0700 (PDT) In-Reply-To: <1460639824-9976-3-git-send-email-dthompson2@worcester.edu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Thompson Cc: guix-devel@gnu.org Hey David, On 04/14/16 16:17, David Thompson wrote: > + (substitute-keyword-arguments (package-arguments xgcc) > + ((#:phases phases) > + `(modify-phases ,phases > + ;; Without a working multilib build, the resulting GCC lacks > + ;; support for nearly every AVR chip. > + (add-after 'unpack 'fix-genmultilib > + (lambda _ > + (substitute* "gcc/genmultilib" > + (("#!/bin/sh") (string-append "#!" (which "sh")))) > + #t)))) I think we should add fix-genmultilib to one of the existing standard phases because this problem appears to Ricardo's arm-none-eabi cross-toolchain as well. All the cross-toolchains will benefit from this. Other than that, we have a working toolchain at last :-D Thank you, Manolis