From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH 1/2] gnu: Add python-mpd2 Date: Thu, 18 Feb 2016 22:08:12 +0000 Message-ID: <56C640CC.1080105@cbaines.net> References: <1455830814-4977-1-git-send-email-mail@cbaines.net> <1455830814-4977-2-git-send-email-mail@cbaines.net> <20160218220047.GA9390@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0RBM6iRcnokhuja5RrlOL3HfWDhtVGecL" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWkJ-0006MH-Gz for guix-devel@gnu.org; Thu, 18 Feb 2016 17:08:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWWkF-0001Nh-FH for guix-devel@gnu.org; Thu, 18 Feb 2016 17:08:23 -0500 Received: from li622-129.members.linode.com ([212.71.249.129]:47505 helo=mira.cbaines.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWkF-0001Na-7U for guix-devel@gnu.org; Thu, 18 Feb 2016 17:08:19 -0500 In-Reply-To: <20160218220047.GA9390@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0RBM6iRcnokhuja5RrlOL3HfWDhtVGecL Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 18/02/16 22:00, Leo Famulari wrote: > On Thu, Feb 18, 2016 at 09:26:53PM +0000, Christopher Baines wrote: >> * gnu/packages/python.scm (python-mpd2): New variable >> * gnu/packages/python.scm Import lgpl3. >=20 > I actually have a patch for this in a WIP tree (attached). Based on the= > differences, and the fact that I have already made the changes requeste= d > below, I think my version of the patch should be used. My patch also > adds a python-2 version; when possible, it's preferred to add both > versions. >=20 > What do you think? That's fine by me. >> + (build-system python-build-system) >> + (arguments >> + `(#:phases >> + (alist-replace >> + 'check >> + (lambda _ (zero? (system* "python" "mpd_test.py"))) >> + %standard-phases))) >> + (inputs >> + `(("python-setuptools" ,python-setuptools) >> + ("python-mock" ,python-mock) >> + ("python-unittest2" ,python-unittest2))) >=20 > I don't believe that unittest2 is needed. I can build both > python-variants without it. =46rom looking at the source, I think its only needed for running the tests with python2.6 [1]. 1: https://github.com/Mic92/python-mpd2/blob/6818984462552dbc7ca85d014f5cf9a= 8a1e81aec/mpd_test.py#L14 > Setuptools is only needed for the python2-variant. >=20 > And, I think mock is only needed at build-time, so it would be a > native-input. I though native inputs had something to do with architectures, which I guess won't matter here, so why is it not just an input? --0RBM6iRcnokhuja5RrlOL3HfWDhtVGecL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWxkDMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzRTg5RUVFNzQ1OEU3MjBEOTc1NEUwQjI1 RTI4QTMzQjBCODRGNTc3AAoJEF4oozsLhPV3FY8QAJmJnEmfsNCUNPiFkta3AaRb 6JWASKbtrpVr3Kj3I2KT9o2Rr1qDAVNLUzjfInC2BHR4Nwf5sNMl2GW6l15VG2Al OuHHs8oXWd98bdN8Zk4rtGJkqokoRRFbpX81MwKwL1HzjjvgggvqO+X04LQQ/CBv W7c+RbxVIA1e3zIAU8FfxukJN8wGAMICZ+a1FxHcDIin89BP//F8wXLrPNo2Rhai bILMc8gcPUVvv6XrmO4J0EDZXE7Nd5susiXVFnWesJJTLM6finCsX8F8K6WtwoBJ cZ5PSsDvSIl4vcZ83Td7oeF44Gli4Ybq2CUhFfRmGvkFTLI/hgVEs92ZybjyzYK/ HAHI49SwfF1B666YsxryyFky8spt4qvgT2Nj9YoRSpEFQ5b0/nx+vJGrGUAXYG1p TF73vU89wGoEhfLWaae0Lbf+YVEMhhwZQIgKuhwI/esXlG5lJMR1xjoLw0hxfFed im4MBQkIwWWOTqnMqjiHcFr5Z61uO0vsUjQovH+cgOpOYGS8271Pf5ljFhpKHL2R hU+R3CPjhYeSotZO1iW/Qwyznmt8cxEAsC1PZ+pSDU7TlLfpBXMzbaxE4r5SkgCz PXkKwfOwlGBDEVlN0ODdvVPkg5fhJjGKcx4UKQuClQtNto8DZDZKcdMJULrih7bU 64pKVWyNmoXzMyLDVrx4 =x2by -----END PGP SIGNATURE----- --0RBM6iRcnokhuja5RrlOL3HfWDhtVGecL--