From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH 3/3] gnu: Add vcsh Date: Thu, 18 Feb 2016 21:04:11 +0000 Message-ID: <56C631CB.7000302@cbaines.net> References: <1455379675-27516-1-git-send-email-mail@cbaines.net> <1455379675-27516-4-git-send-email-mail@cbaines.net> <20160213224108.GC1176@jasmine> <56C0E530.9010604@cbaines.net> <20160217181107.GA31074@solar> <56C4C2FC.7070107@cbaines.net> <20160218001144.GA26345@jasmine> <20160218200100.GC3445@solar> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5HfbxRErlRGiB4FANPFV3uVTJ6pF0IihU" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWVkM-0001QZ-EI for guix-devel@gnu.org; Thu, 18 Feb 2016 16:04:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWVkJ-0003p6-7g for guix-devel@gnu.org; Thu, 18 Feb 2016 16:04:22 -0500 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:34209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWVkJ-0003ov-1c for guix-devel@gnu.org; Thu, 18 Feb 2016 16:04:19 -0500 In-Reply-To: <20160218200100.GC3445@solar> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge , Leo Famulari Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5HfbxRErlRGiB4FANPFV3uVTJ6pF0IihU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 18/02/16 20:01, Andreas Enge wrote: > On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: >> I missed this earlier. We don't usually propagate this sort of "end-us= er >> program" dependencies. For example rsync does not propagate ssh; the >> user must install ssh. [0] >=20 > I think the cleanest approach would be to patch all calls to "git" in > the vcsh shell script by calls to "/gnu/store/xxxx-git-.../bin/git", > where the base name is taken as "(assoc-ref %build-inputs "git")" or th= e like. >=20 > What do you think? >=20 > It might be as simple as a call in a phase to "substitute*", replacing > "git " by the path+" ". The script is a bit annoying in that it scatter= s > calls to git all over the place. It would be cleaner to define "GIT=3Dg= it" > at the start of the file, and then always call "$(GIT)". Maybe that is > something to suggest to the upstream author? =3D Yep, I can look in to doing this. --5HfbxRErlRGiB4FANPFV3uVTJ6pF0IihU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWxjHLXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzRTg5RUVFNzQ1OEU3MjBEOTc1NEUwQjI1 RTI4QTMzQjBCODRGNTc3AAoJEF4oozsLhPV3GKwQAIT9sUp+2pAAhWj2jjU/GP9q wAas62BOtAvt7WzZAGqz6vYnpuRfuoXTPayeUCrBs/0r9FY9vUmcoVqUInYJha1w AfrJ0xcA2fO9U0ntDAKpMYoI/CRplxON9Z4DO8oPhM2igfTWjcKXuGCRKHB4n95Z mJ/epmKkBkyhPKwJLIR7m1/hEQ8BpGKug8Su1XXBrcOwUkl+cE+6WnM9jj4aSsj7 MlZJW6z+/vdjZWQ57I4Q6HmfxNUMjcCigsD01E+djBt+q0qm7eusxgEU54OLwn6x C5jaFlY03Y197NfJFm7OGKxxMYPNa05/Lh7zU4+I6XFKj4JNgdGQFBTueDki22Rj lbJ3lwnIhqPSG2SLSBBJ3DZwfD5+hXhp/srvpRUx5IKLoiMCnvOSI0H+Um/5O4bx GXQ/+9IAtB4byizNxbXWwXTc4k7V07iXY9WfcqpcSh9sFqhCop2Arnl8dW7RT9cJ CUx8F1X9MHAPinkTPlqMaj1O2TtcWp7MiD67A2l45HBIlzuawndiqgEHzZfbgRVM gfh2c3d9BKZgSbgDZSjjqfGyMP135P+8EmfPotNgm5/SJbxPokMK7Xt+o4SVJVdi K524qRaAeSpRbwf0CBJm9MbVGcK3PDPHmfTFqqz2vhOjKW/aCLxZl09bPZ0UnzGQ aL5zj0g7le6NXtYiScl7 =PwC9 -----END PGP SIGNATURE----- --5HfbxRErlRGiB4FANPFV3uVTJ6pF0IihU--